You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sandip-db (via GitHub)" <gi...@apache.org> on 2023/10/18 02:35:44 UTC
[PR] [SPARK-45562][SQL][FOLLOW-UP] XML: Make 'rowTag' option check case insensitive [spark]
sandip-db opened a new pull request, #43416:
URL: https://github.com/apache/spark/pull/43416
### What changes were proposed in this pull request?
[PR 43389](https://github.com/apache/spark/pull/43389) made `rowTag` option required for XML read and write. However, the option check was done in a case sensitive manner. This PR makes the check case-insensitive.
### Why are the changes needed?
Options are case-insensitive.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit test.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45562][SQL][FOLLOW-UP] XML: Make 'rowTag' option check case insensitive [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43416:
URL: https://github.com/apache/spark/pull/43416#issuecomment-1769867625
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45562][SQL][FOLLOW-UP] XML: Make 'rowTag' option check case insensitive [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43416: [SPARK-45562][SQL][FOLLOW-UP] XML: Make 'rowTag' option check case insensitive
URL: https://github.com/apache/spark/pull/43416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45562][SQL][FOLLOW-UP] XML: Make 'rowTag' option check case insensitive [spark]
Posted by "sandip-db (via GitHub)" <gi...@apache.org>.
sandip-db commented on PR #43416:
URL: https://github.com/apache/spark/pull/43416#issuecomment-1767575886
> Where check the case insensitive?
Options are converted to caseInsensitiveMap here:
https://github.com/apache/spark/pull/43416/files#diff-8da00c2ce6281b3fef7cf24d000ad2d66d42abd26d8e3c45d76ac48b73e9ff67L47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45562][SQL][FOLLOW-UP] XML: Make 'rowTag' option check case insensitive [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #43416:
URL: https://github.com/apache/spark/pull/43416#issuecomment-1767579420
> Options are converted to caseInsensitiveMap here: https://github.com/apache/spark/pull/43416/files#diff-8da00c2ce6281b3fef7cf24d000ad2d66d42abd26d8e3c45d76ac48b73e9ff67L47
Thank you for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org