[GitHub] [spark] LuciferYang commented on a change in pull request #36035: [SPARK-38756][CORE][DOCS] Clean up invalid security configuration items in `TransportConf`

[GitBox <gi...@apache.org>]

LuciferYang commented on a change in pull request #36035:
URL: https://github.com/apache/spark/pull/36035#discussion_r840332983



##########
File path: common/network-common/src/test/java/org/apache/spark/network/crypto/AuthEngineSuite.java
##########
@@ -188,19 +186,6 @@ public void testMismatchedSecret() throws Exception {
     }
   }
 
-  @Test(expected = AssertionError.class)

Review comment:
       This UT before `Update Spark key negotiation protocol` as follows:
   
   ```scala
     @Test(expected = InvalidKeyException.class)
     public void testBadKeySize() throws Exception {
       Map<String, String> mconf = ImmutableMap.of("spark.network.crypto.keyLength", "42");
       TransportConf conf = new TransportConf("rpc", new MapConfigProvider(mconf));
   
       try (AuthEngine engine = new AuthEngine("appId", "secret", conf)) {
         engine.challenge();
         fail("Should have failed to create challenge message.");
   
         // Call close explicitly to make sure it's idempotent.
         engine.close();
       }
     }
   ```
   however, `spark.network.crypto.keyLength` is no longer used now, so this UT is unnecessary
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org