You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David James <ja...@gmail.com> on 2005/09/04 18:06:44 UTC

[PATCH] Declare callbacks2 at top of scope in compat_open (was: Re: svn trunk r16039: FAIL (win32 ra_local))

On 9/4/05, D.J. Heap <dj...@gmail.com> wrote:
> It appears some non-compliant code has crept into in wrapper_template.h:
>  
> d:\svnbuild\src-trunk\subversion\libsvn_ra_svn\../libsvn_ra/wrapper_template.h(62)
> : error C2275: 'svn_ra_callbacks2_t' : illegal use of this type as an
> expression
>  
>  The variable is not being declared at the top of the scope and MSVC, at
> least, is not happy about it.

Does the attached patch help?

[[[

* subversion/libsvn_ra/wrapper_template.h:
  (compat_open): Move declaration of callbacks2 to top of function
  scope.

]]]


Cheers,

David


-- 
David James -- http://www.cs.toronto.edu/~james

Re: [PATCH] Declare callbacks2 at top of scope in compat_open (was: Re: svn trunk r16039: FAIL (win32 ra_local))

Posted by David Anderson <da...@calixo.net>.
D.J. Heap wrote:
> Yes, it builds fine with the patch and tests are running.

And commited in r16044, with credit to David James for the patch.

Thanks for the report!

- Dave.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Declare callbacks2 at top of scope in compat_open (was: Re: svn trunk r16039: FAIL (win32 ra_local))

Posted by "D.J. Heap" <dj...@gmail.com>.
On 9/4/05, David Anderson <da...@calixo.net> wrote:
> 
> David James wrote:
> > Does the attached patch help?
> 
> It should. I've just done something to the same effect in my working
> copy. To avoid adding to revision clutter, could someone with MSVC
> test-drive the patch? If it solves MSVC's problem (and no others
> arise), I'll commit it.
> 
> - Dave.
> 

Yes, it builds fine with the patch and tests are running.

Thanks!

DJ

Re: [PATCH] Declare callbacks2 at top of scope in compat_open (was: Re: svn trunk r16039: FAIL (win32 ra_local))

Posted by David Anderson <da...@calixo.net>.
David James wrote:
> Does the attached patch help?

It should.  I've just done something to the same effect in my working 
copy.  To avoid adding to revision clutter, could someone with MSVC 
test-drive the patch?  If it solves MSVC's problem (and no others 
arise), I'll commit it.

- Dave.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org