[GitHub] jlahoda commented on a change in pull request #1068: Improve building of platform on JDK11

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #1068: Improve building of platform on JDK11
URL: https://github.com/apache/incubator-netbeans/pull/1068#discussion_r244792126
 
 

 ##########
 File path: nbbuild/build.xml
 ##########
 @@ -460,6 +465,8 @@ Hg ID:    ${hg.id}
           <property name="cluster.config" value="platform"/>
           <property name="test.type" value="test-unit"/>
           <property name="test-unit-sys-prop.ignore.random.failures" value="true"/>
+          <property name="permit.jdk9.builds" value="true"/>
 
 Review comment:
   For completeness, as I believe this is obvious, the purpose of permit.jdk9.builds is to avoid producing builds that are not guaranteed to run on JDK 8. (I.e. explicitly accepting this fact the build won't necessarily be suitable for JDK 8, to avoid surprises.)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists