You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:49:44 UTC
[GitHub] [cassandra] blerer opened a new pull request #800: CASSANDRA-16186 (3.11): Remove the SEPExecutor blocking behavior
blerer opened a new pull request #800:
URL: https://github.com/apache/cassandra/pull/800
If the number of tasks added to a SEPExecutor exceed the max queue size, the threads adding those task will be block until enough space become available for all the blocked tasks. At this point all the blocked threads will be released at once.
As the maxTasksQueued was always set to INTEGER.MAX_VALUE, the code was in practice never using. By consequence, removing the code was a better option than trying to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] blerer commented on pull request #800: CASSANDRA-16186 (3.11): Remove the SEPExecutor blocking behavior
Posted by GitBox <gi...@apache.org>.
blerer commented on pull request #800:
URL: https://github.com/apache/cassandra/pull/800#issuecomment-724620619
Merged manually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] blerer closed pull request #800: CASSANDRA-16186 (3.11): Remove the SEPExecutor blocking behavior
Posted by GitBox <gi...@apache.org>.
blerer closed pull request #800:
URL: https://github.com/apache/cassandra/pull/800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] adelapena commented on a change in pull request #800: CASSANDRA-16186 (3.11): Remove the SEPExecutor blocking behavior
Posted by GitBox <gi...@apache.org>.
adelapena commented on a change in pull request #800:
URL: https://github.com/apache/cassandra/pull/800#discussion_r518229958
##########
File path: src/java/org/apache/cassandra/concurrent/SEPExecutor.java
##########
@@ -35,16 +35,13 @@
public final int maxWorkers;
public final String name;
- private final int maxTasksQueued;
private final SEPMetrics metrics;
// stores both a set of work permits and task permits:
// bottom 32 bits are number of queued tasks, in the range [0..maxTasksQueued] (initially 0)
// top 32 bits are number of work permits available in the range [0..maxWorkers] (initially maxWorkers)
private final AtomicLong permits = new AtomicLong();
- // producers wait on this when there is no room on the queue
- private final WaitQueue hasRoom = new WaitQueue();
Review comment:
Nit: This leaves a unused import of `WaitQueue`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] blerer commented on a change in pull request #800: CASSANDRA-16186 (3.11): Remove the SEPExecutor blocking behavior
Posted by GitBox <gi...@apache.org>.
blerer commented on a change in pull request #800:
URL: https://github.com/apache/cassandra/pull/800#discussion_r518729461
##########
File path: src/java/org/apache/cassandra/concurrent/SEPExecutor.java
##########
@@ -35,16 +35,13 @@
public final int maxWorkers;
public final String name;
- private final int maxTasksQueued;
private final SEPMetrics metrics;
// stores both a set of work permits and task permits:
// bottom 32 bits are number of queued tasks, in the range [0..maxTasksQueued] (initially 0)
// top 32 bits are number of work permits available in the range [0..maxWorkers] (initially maxWorkers)
private final AtomicLong permits = new AtomicLong();
- // producers wait on this when there is no room on the queue
- private final WaitQueue hasRoom = new WaitQueue();
Review comment:
I will fix it on commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org