[GitHub] [pulsar] equanz commented on pull request #11570: [Issue 11496][C++] Allow partitioned producers to start lazily

[GitBox <gi...@apache.org>]

equanz commented on pull request #11570:
URL: https://github.com/apache/pulsar/pull/11570#issuecomment-897463605


   Thank you for your comments about PIP-79.
   I have a few comments. I think these comments don't block merging.
   
   For authn/authz backward compatibility reason, I think the internal producer should be connected to broker before completing the creation of partitioned producer( https://mail-archives.apache.org/mod_mbox/pulsar-dev/202102.mbox/%3CCAO2yDybn3sqPJV32YqvYndk%3D8mxNKodcGB4GE3QmUs8F9m8YUw%40mail.gmail.com%3E ). However, it isn't critical because the change affects when ProducerConfiguration.setLazyStartPartitionedProducers(true) is set.
   
   As mentioned in [here](https://github.com/apache/pulsar/wiki/PIP-79%3A-Reduce-redundant-producers-from-partitioned-producer#change-partitionedtopicstats-about-producer), partitioned producer stats will be incorrect if each partition has different number of producers. I tried to fix this issue in the PIP-79 (It will be fixed in https://github.com/apache/pulsar/pull/10534 at Java client).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org