You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "f1amingo (via GitHub)" <gi...@apache.org> on 2024/10/17 09:38:58 UTC
[I] [Enhancement] Remove netty codec threads for better performance [rocketmq]
f1amingo opened a new issue, #8837:
URL: https://github.com/apache/rocketmq/issues/8837
### Before Creating the Enhancement Request
- [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature.
### Summary
In the current implementation, a codec thread pool is set up for Netty, which is used to perform tasks such as encoding/decoding, and statistics.
We found that removing the codec thread pool and directly assigning these computational tasks to the NIO selector threads results in performance improvement.
Since these tasks do not involve IO operations, they will not block the NIO selector threads.
### Motivation
Our stress test results show that removing the codec thread pool can achieve higher TPS (5% increase) and also reduce CPU usage (4% reduction).
#### [TPS Comparison] Before:

#### [TPS Comparison] After:

----
#### [CPU Comparison] Before:

#### [CPU Comparison] After:

### Describe the Solution You'd Like
Remove the codec thread pool `NettyRemotingServer #defaultEventExecutorGroup`
### Describe Alternatives You've Considered
No
### Additional Context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Enhancement] Remove netty codec threads for better performance [rocketmq]
Posted by "f1amingo (via GitHub)" <gi...@apache.org>.
f1amingo commented on issue #8837:
URL: https://github.com/apache/rocketmq/issues/8837#issuecomment-2419092071
A switch has already been added.
Close issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Enhancement] Remove netty codec threads for better performance [rocketmq]
Posted by "f1amingo (via GitHub)" <gi...@apache.org>.
f1amingo closed issue #8837: [Enhancement] Remove netty codec threads for better performance
URL: https://github.com/apache/rocketmq/issues/8837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org