You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "Jayden-Chiu (via GitHub)" <gi...@apache.org> on 2025/09/29 06:43:20 UTC
[PR] Add support for MySQL Metastore [polaris]
Jayden-Chiu opened a new pull request, #2704:
URL: https://github.com/apache/polaris/pull/2704
<!--
Possible security vulnerabilities: STOP here and contact security@apache.org instead!
Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated"
Please update this summary field:
The summary should cover these topics, if applicable:
* the motivation for the change
* a description of the status quo, for example the current behavior
* the desired behavior
* etc
PR checklist:
- Do a self-review of your code before opening a pull request
- Make sure that there's good test coverage for the changes included in this PR
- Run tests locally before pushing a PR (./gradlew check)
- Code should have comments where applicable. Particularly hard-to-understand
areas deserve good in-line documentation.
- Include changes and enhancements to the documentation (in site/content/in-dev/unreleased)
- For Work In Progress Pull Requests, please use the Draft PR feature.
Make sure to add the information BELOW this comment.
Everything in this comment will NOT be added to the PR description.
-->
As discussed in #2491 , there is currently no support for MySQL as a metastore. many organizations (mine included) rely on existing MySQL infrastructure and this PR adds MySQL support to the `relational-jdbc` module with tests. This PR mostly extends existing code for Postgres support, adding MySQL to `DatabaseType` enum, and changing existing methods to handle MySQL `DatabaseType` and adding MySQL JDBC driver to `persistence/relational-jdbc/build.gradle.kts` and `runtime/server/build.gradle.kts`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for MySQL Metastore [polaris]
Posted by "Jayden-Chiu (via GitHub)" <gi...@apache.org>.
Jayden-Chiu commented on PR #2704:
URL: https://github.com/apache/polaris/pull/2704#issuecomment-3348987376
Sorry, missed this conversation, maybe I will create documentation later on which references this PR on how to get MySQL support if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for MySQL Metastore [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #2704:
URL: https://github.com/apache/polaris/pull/2704#discussion_r2404580863
##########
persistence/relational-jdbc/src/main/resources/mysql/schema-v1.sql:
##########
Review Comment:
So rather than just starting with mysql v3, you could just start with mysql v1 with all the tables that postgres v3 has.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for MySQL Metastore [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2704:
URL: https://github.com/apache/polaris/pull/2704#discussion_r2389603309
##########
persistence/relational-jdbc/src/main/resources/mysql/schema-v1.sql:
##########
Review Comment:
Why add earlier schemas? MySQL was not supported when v1 was current 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for MySQL Metastore [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #2704:
URL: https://github.com/apache/polaris/pull/2704#discussion_r2404580609
##########
persistence/relational-jdbc/src/main/resources/mysql/schema-v1.sql:
##########
Review Comment:
Since this is currently only [checked](https://github.com/apache/polaris/blob/10f4bc50a7f6e24343072ee4033d295e718b45fe/persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java#L764) within a persistence impl, these version numbers are also per persistence impl. There's no requirement that MySQL vN align with postgres vN.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for MySQL Metastore [polaris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2704:
URL: https://github.com/apache/polaris/pull/2704#issuecomment-3488826461
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for MySQL Metastore [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2704:
URL: https://github.com/apache/polaris/pull/2704#discussion_r2389596834
##########
runtime/server/build.gradle.kts:
##########
@@ -44,6 +44,8 @@ dependencies {
runtimeOnly("org.postgresql:postgresql")
runtimeOnly(project(":polaris-relational-jdbc"))
runtimeOnly("io.quarkus:quarkus-jdbc-postgresql")
+ implementation(libs.mysql.connector.j)
Review Comment:
Everything _except_ the driver is acceptable, I think.
So, @Jayden-Chiu : you may want to keep the java code changes, but remove the driver dependency. That would be mergeable from my POV (pending reviews from other maintainers, of course). Then, instructions on bundling MySQL Connector in a local build could be much simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for MySQL Metastore [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2704:
URL: https://github.com/apache/polaris/pull/2704#discussion_r2389596834
##########
runtime/server/build.gradle.kts:
##########
@@ -44,6 +44,8 @@ dependencies {
runtimeOnly("org.postgresql:postgresql")
runtimeOnly(project(":polaris-relational-jdbc"))
runtimeOnly("io.quarkus:quarkus-jdbc-postgresql")
+ implementation(libs.mysql.connector.j)
Review Comment:
Everything _except_ the driver is acceptable, I think.
So, @Jayden-Chiu : you may want to keep the java code changes, but remove the driver dependency. That would be mergeable from my POV (pending reviews from other maintainers, of course). Then, instructions on bundling MySQL Connector in a local build could be much simpler.
If the instructed for downstream builds with MySQL were added to a README or docs, that would make a well-rounded PR, from my POV.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for MySQL Metastore [polaris]
Posted by "Jayden-Chiu (via GitHub)" <gi...@apache.org>.
Jayden-Chiu commented on code in PR #2704:
URL: https://github.com/apache/polaris/pull/2704#discussion_r2389229097
##########
runtime/server/build.gradle.kts:
##########
@@ -44,6 +44,8 @@ dependencies {
runtimeOnly("org.postgresql:postgresql")
runtimeOnly(project(":polaris-relational-jdbc"))
runtimeOnly("io.quarkus:quarkus-jdbc-postgresql")
+ implementation(libs.mysql.connector.j)
Review Comment:
Sorry, missed this conversation, maybe I will create documentation later on which references this PR on how to get MySQL support if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for MySQL Metastore [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #2704:
URL: https://github.com/apache/polaris/pull/2704#discussion_r2387114660
##########
runtime/server/build.gradle.kts:
##########
@@ -44,6 +44,8 @@ dependencies {
runtimeOnly("org.postgresql:postgresql")
runtimeOnly(project(":polaris-relational-jdbc"))
runtimeOnly("io.quarkus:quarkus-jdbc-postgresql")
+ implementation(libs.mysql.connector.j)
Review Comment:
We cannot ship this dependency it seems.
See this comment:
https://github.com/apache/polaris/issues/2491#issuecomment-3253157608
\cc @jbonofre
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for MySQL Metastore [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2704:
URL: https://github.com/apache/polaris/pull/2704#discussion_r2388831533
##########
runtime/server/build.gradle.kts:
##########
@@ -44,6 +44,8 @@ dependencies {
runtimeOnly("org.postgresql:postgresql")
runtimeOnly(project(":polaris-relational-jdbc"))
runtimeOnly("io.quarkus:quarkus-jdbc-postgresql")
+ implementation(libs.mysql.connector.j)
Review Comment:
Yes, the connector license is not compatible with ASF, AFAIK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for MySQL Metastore [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2704:
URL: https://github.com/apache/polaris/pull/2704#discussion_r2389596834
##########
runtime/server/build.gradle.kts:
##########
@@ -44,6 +44,8 @@ dependencies {
runtimeOnly("org.postgresql:postgresql")
runtimeOnly(project(":polaris-relational-jdbc"))
runtimeOnly("io.quarkus:quarkus-jdbc-postgresql")
+ implementation(libs.mysql.connector.j)
Review Comment:
Everything _except_ the driver is acceptable, I think.
So, @Jayden-Chiu : you may want to keep the java code changes, but remove the driver dependency. That would be mergeable from my POV (pending reviews from other maintainers, of course). Then, instructions on bundling MySQL Connector in a local build could be much simpler.
If the instructed for downstream build with MySQL were added to a README or docs, that would make a well-rounded PR, from my POV.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for MySQL Metastore [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2704:
URL: https://github.com/apache/polaris/pull/2704#discussion_r2389596834
##########
runtime/server/build.gradle.kts:
##########
@@ -44,6 +44,8 @@ dependencies {
runtimeOnly("org.postgresql:postgresql")
runtimeOnly(project(":polaris-relational-jdbc"))
runtimeOnly("io.quarkus:quarkus-jdbc-postgresql")
+ implementation(libs.mysql.connector.j)
Review Comment:
Everything _except_ the driver is acceptable, I think.
So, @Jayden-Chiu : you may want to keep the java code changes, but remove the driver dependency. That would be mergeable from my POV (pending reviews from other maintainers, of course). Then, instructions on bundling MySQL Connector in a local build could be much simpler.
If the instructions for downstream builds with MySQL were added to a README or docs, that would make a well-rounded PR, from my POV.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for MySQL Metastore [polaris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2704: Add support for MySQL Metastore
URL: https://github.com/apache/polaris/pull/2704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org