You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by gi...@git.apache.org on 2017/07/12 22:56:05 UTC

[GitHub] nkurihar commented on a change in pull request #559: Add empty check for subscription name

nkurihar commented on a change in pull request #559: Add empty check for subscription name
URL: https://github.com/apache/incubator-pulsar/pull/559#discussion_r127092959
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
 ##########
 @@ -349,6 +350,12 @@ public void removeProducer(Producer producer) {
 
         final CompletableFuture<Consumer> future = new CompletableFuture<>();
 
+        if (isBlank(subscriptionName)) {
+            log.warn("[{}] Empty subscription name", topic);
 
 Review comment:
   @merlimat I changed the log level to debug.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services