You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Robert Kanter (JIRA)" <ji...@apache.org> on 2012/09/25 22:46:07 UTC
[jira] [Created] (OOZIE-999) XLogStreamer requires
log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or
streaming logs to web UI and CLI don't work
Robert Kanter created OOZIE-999:
-----------------------------------
Summary: XLogStreamer requires log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or streaming logs to web UI and CLI don't work
Key: OOZIE-999
URL: https://issues.apache.org/jira/browse/OOZIE-999
Project: Oozie
Issue Type: Bug
Reporter: Robert Kanter
Assignee: Robert Kanter
Fix For: trunk
XLogStreamer.constructPattern() contains:
{code}
StringBuilder sb = new StringBuilder();
if (noFilter) {
sb.append("(.*)");
}
else {
sb.append("(.* - ");
for (int i = 0; i < parameters.size(); i++) {
sb.append(parameters.get(i) + "\\[");
sb.append(filterParams.get(parameters.get(i)) + "\\] ");
}
sb.append(".*)");
}
filterPattern = Pattern.compile(sb.toString());
{code}
which causes streaming logs to the web UI and CLI to not work if log4j.appender.oozie.layout.ConversionPattern in log4j.properties contains a "-" (dash).
We should try to remove this restriction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-999) XLogStreamer requires
log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or
streaming logs to web UI and CLI don't work
Posted by "Robert Kanter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465259#comment-13465259 ]
Robert Kanter commented on OOZIE-999:
-------------------------------------
The existing test effectively already tests this; the conversion pattern dictates how the lines in the log will be formatted and the new test has lines without a '-' (and with other characters). Unless you meant a test where I actually test streaming when the conversion pattern doesn't have a dash (which would be a good test to add).
> XLogStreamer requires log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or streaming logs to web UI and CLI don't work
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-999
> URL: https://issues.apache.org/jira/browse/OOZIE-999
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Fix For: trunk
>
> Attachments: OOZIE-999.patch
>
>
> XLogStreamer.constructPattern() contains:
> {code}
> StringBuilder sb = new StringBuilder();
> if (noFilter) {
> sb.append("(.*)");
> }
> else {
> sb.append("(.* - "); // <----- Here's the dash
> for (int i = 0; i < parameters.size(); i++) {
> sb.append(parameters.get(i) + "\\[");
> sb.append(filterParams.get(parameters.get(i)) + "\\] ");
> }
> sb.append(".*)");
> }
> filterPattern = Pattern.compile(sb.toString());
> {code}
> which causes streaming logs to the web UI and CLI to not work if log4j.appender.oozie.layout.ConversionPattern in log4j.properties contains a "-" (dash).
> We should try to remove this restriction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-999) XLogStreamer requires
log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or
streaming logs to web UI and CLI don't work
Posted by "Robert Kanter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Kanter updated OOZIE-999:
--------------------------------
Attachment: OOZIE-999.patch
New patch has a test that actually directly checks the streaming
> XLogStreamer requires log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or streaming logs to web UI and CLI don't work
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-999
> URL: https://issues.apache.org/jira/browse/OOZIE-999
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Fix For: trunk
>
> Attachments: OOZIE-999.patch, OOZIE-999.patch
>
>
> XLogStreamer.constructPattern() contains:
> {code}
> StringBuilder sb = new StringBuilder();
> if (noFilter) {
> sb.append("(.*)");
> }
> else {
> sb.append("(.* - "); // <----- Here's the dash
> for (int i = 0; i < parameters.size(); i++) {
> sb.append(parameters.get(i) + "\\[");
> sb.append(filterParams.get(parameters.get(i)) + "\\] ");
> }
> sb.append(".*)");
> }
> filterPattern = Pattern.compile(sb.toString());
> {code}
> which causes streaming logs to the web UI and CLI to not work if log4j.appender.oozie.layout.ConversionPattern in log4j.properties contains a "-" (dash).
> We should try to remove this restriction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-999) XLogStreamer requires
log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or
streaming logs to web UI and CLI don't work
Posted by "Robert Kanter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463196#comment-13463196 ]
Robert Kanter commented on OOZIE-999:
-------------------------------------
Does anyone know why the dash is there?
> XLogStreamer requires log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or streaming logs to web UI and CLI don't work
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-999
> URL: https://issues.apache.org/jira/browse/OOZIE-999
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Fix For: trunk
>
>
> XLogStreamer.constructPattern() contains:
> {code}
> StringBuilder sb = new StringBuilder();
> if (noFilter) {
> sb.append("(.*)");
> }
> else {
> sb.append("(.* - ");
> for (int i = 0; i < parameters.size(); i++) {
> sb.append(parameters.get(i) + "\\[");
> sb.append(filterParams.get(parameters.get(i)) + "\\] ");
> }
> sb.append(".*)");
> }
> filterPattern = Pattern.compile(sb.toString());
> {code}
> which causes streaming logs to the web UI and CLI to not work if log4j.appender.oozie.layout.ConversionPattern in log4j.properties contains a "-" (dash).
> We should try to remove this restriction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-999) XLogStreamer requires
log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or
streaming logs to web UI and CLI don't work
Posted by "Robert Kanter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Kanter updated OOZIE-999:
--------------------------------
Description:
XLogStreamer.constructPattern() contains:
{code}
StringBuilder sb = new StringBuilder();
if (noFilter) {
sb.append("(.*)");
}
else {
sb.append("(.* - "); // <----- Here's the dash
for (int i = 0; i < parameters.size(); i++) {
sb.append(parameters.get(i) + "\\[");
sb.append(filterParams.get(parameters.get(i)) + "\\] ");
}
sb.append(".*)");
}
filterPattern = Pattern.compile(sb.toString());
{code}
which causes streaming logs to the web UI and CLI to not work if log4j.appender.oozie.layout.ConversionPattern in log4j.properties contains a "-" (dash).
We should try to remove this restriction.
was:
XLogStreamer.constructPattern() contains:
{code}
StringBuilder sb = new StringBuilder();
if (noFilter) {
sb.append("(.*)");
}
else {
sb.append("(.* - ");
for (int i = 0; i < parameters.size(); i++) {
sb.append(parameters.get(i) + "\\[");
sb.append(filterParams.get(parameters.get(i)) + "\\] ");
}
sb.append(".*)");
}
filterPattern = Pattern.compile(sb.toString());
{code}
which causes streaming logs to the web UI and CLI to not work if log4j.appender.oozie.layout.ConversionPattern in log4j.properties contains a "-" (dash).
We should try to remove this restriction.
> XLogStreamer requires log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or streaming logs to web UI and CLI don't work
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-999
> URL: https://issues.apache.org/jira/browse/OOZIE-999
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Fix For: trunk
>
>
> XLogStreamer.constructPattern() contains:
> {code}
> StringBuilder sb = new StringBuilder();
> if (noFilter) {
> sb.append("(.*)");
> }
> else {
> sb.append("(.* - "); // <----- Here's the dash
> for (int i = 0; i < parameters.size(); i++) {
> sb.append(parameters.get(i) + "\\[");
> sb.append(filterParams.get(parameters.get(i)) + "\\] ");
> }
> sb.append(".*)");
> }
> filterPattern = Pattern.compile(sb.toString());
> {code}
> which causes streaming logs to the web UI and CLI to not work if log4j.appender.oozie.layout.ConversionPattern in log4j.properties contains a "-" (dash).
> We should try to remove this restriction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-999) XLogStreamer requires
log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or
streaming logs to web UI and CLI don't work
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465914#comment-13465914 ]
Hadoop QA commented on OOZIE-999:
---------------------------------
Testing JIRA OOZIE-999
Cleaning local svn workspace
{code}
----------------------------
+1 PATCH_APPLIES
CLEAN cleaned target directories
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch does adds/modifies 3 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 912
Tests failures: 0
Tests errors: 0
+1 DISTRO
+1 distro tarball builds with the patch
----------------------------
{code}
The full output of the test-patch run is available at
https://builds.apache.org/job/oozie-trunk-precommit-build/114/
> XLogStreamer requires log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or streaming logs to web UI and CLI don't work
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-999
> URL: https://issues.apache.org/jira/browse/OOZIE-999
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Fix For: trunk
>
> Attachments: OOZIE-999.patch, OOZIE-999.patch
>
>
> XLogStreamer.constructPattern() contains:
> {code}
> StringBuilder sb = new StringBuilder();
> if (noFilter) {
> sb.append("(.*)");
> }
> else {
> sb.append("(.* - "); // <----- Here's the dash
> for (int i = 0; i < parameters.size(); i++) {
> sb.append(parameters.get(i) + "\\[");
> sb.append(filterParams.get(parameters.get(i)) + "\\] ");
> }
> sb.append(".*)");
> }
> filterPattern = Pattern.compile(sb.toString());
> {code}
> which causes streaming logs to the web UI and CLI to not work if log4j.appender.oozie.layout.ConversionPattern in log4j.properties contains a "-" (dash).
> We should try to remove this restriction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-999) XLogStreamer requires
log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or
streaming logs to web UI and CLI don't work
Posted by "Robert Kanter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463348#comment-13463348 ]
Robert Kanter commented on OOZIE-999:
-------------------------------------
>From some very limited testing I just did, removing the dash doesn't seem to break anything.
> XLogStreamer requires log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or streaming logs to web UI and CLI don't work
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-999
> URL: https://issues.apache.org/jira/browse/OOZIE-999
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Fix For: trunk
>
>
> XLogStreamer.constructPattern() contains:
> {code}
> StringBuilder sb = new StringBuilder();
> if (noFilter) {
> sb.append("(.*)");
> }
> else {
> sb.append("(.* - "); // <----- Here's the dash
> for (int i = 0; i < parameters.size(); i++) {
> sb.append(parameters.get(i) + "\\[");
> sb.append(filterParams.get(parameters.get(i)) + "\\] ");
> }
> sb.append(".*)");
> }
> filterPattern = Pattern.compile(sb.toString());
> {code}
> which causes streaming logs to the web UI and CLI to not work if log4j.appender.oozie.layout.ConversionPattern in log4j.properties contains a "-" (dash).
> We should try to remove this restriction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-999) XLogStreamer requires
log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or
streaming logs to web UI and CLI don't work
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465859#comment-13465859 ]
Virag Kothari commented on OOZIE-999:
-------------------------------------
Yes, I meant testing streaming after removing the dash from conversion patter property in log4j. Thanks!
> XLogStreamer requires log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or streaming logs to web UI and CLI don't work
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-999
> URL: https://issues.apache.org/jira/browse/OOZIE-999
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Fix For: trunk
>
> Attachments: OOZIE-999.patch
>
>
> XLogStreamer.constructPattern() contains:
> {code}
> StringBuilder sb = new StringBuilder();
> if (noFilter) {
> sb.append("(.*)");
> }
> else {
> sb.append("(.* - "); // <----- Here's the dash
> for (int i = 0; i < parameters.size(); i++) {
> sb.append(parameters.get(i) + "\\[");
> sb.append(filterParams.get(parameters.get(i)) + "\\] ");
> }
> sb.append(".*)");
> }
> filterPattern = Pattern.compile(sb.toString());
> {code}
> which causes streaming logs to the web UI and CLI to not work if log4j.appender.oozie.layout.ConversionPattern in log4j.properties contains a "-" (dash).
> We should try to remove this restriction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-999) XLogStreamer requires
log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or
streaming logs to web UI and CLI don't work
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465146#comment-13465146 ]
Virag Kothari commented on OOZIE-999:
-------------------------------------
Patch looks good to me. I am also not sure why the dash was there in the first place. Just to make sure that things dont break, can you also add a test case where the conversion pattern doesn't have a '-'?.
> XLogStreamer requires log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or streaming logs to web UI and CLI don't work
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-999
> URL: https://issues.apache.org/jira/browse/OOZIE-999
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Fix For: trunk
>
> Attachments: OOZIE-999.patch
>
>
> XLogStreamer.constructPattern() contains:
> {code}
> StringBuilder sb = new StringBuilder();
> if (noFilter) {
> sb.append("(.*)");
> }
> else {
> sb.append("(.* - "); // <----- Here's the dash
> for (int i = 0; i < parameters.size(); i++) {
> sb.append(parameters.get(i) + "\\[");
> sb.append(filterParams.get(parameters.get(i)) + "\\] ");
> }
> sb.append(".*)");
> }
> filterPattern = Pattern.compile(sb.toString());
> {code}
> which causes streaming logs to the web UI and CLI to not work if log4j.appender.oozie.layout.ConversionPattern in log4j.properties contains a "-" (dash).
> We should try to remove this restriction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-999) XLogStreamer requires
log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or
streaming logs to web UI and CLI don't work
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464384#comment-13464384 ]
Hadoop QA commented on OOZIE-999:
---------------------------------
Testing JIRA OOZIE-999
Cleaning local svn workspace
{code}
----------------------------
+1 PATCH_APPLIES
CLEAN cleaned target directories
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch does adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 911
Tests failures: 0
Tests errors: 0
+1 DISTRO
+1 distro tarball builds with the patch
----------------------------
{code}
The full output of the test-patch run is available at
https://builds.apache.org/job/oozie-trunk-precommit-build/112/
> XLogStreamer requires log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or streaming logs to web UI and CLI don't work
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-999
> URL: https://issues.apache.org/jira/browse/OOZIE-999
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Fix For: trunk
>
> Attachments: OOZIE-999.patch
>
>
> XLogStreamer.constructPattern() contains:
> {code}
> StringBuilder sb = new StringBuilder();
> if (noFilter) {
> sb.append("(.*)");
> }
> else {
> sb.append("(.* - "); // <----- Here's the dash
> for (int i = 0; i < parameters.size(); i++) {
> sb.append(parameters.get(i) + "\\[");
> sb.append(filterParams.get(parameters.get(i)) + "\\] ");
> }
> sb.append(".*)");
> }
> filterPattern = Pattern.compile(sb.toString());
> {code}
> which causes streaming logs to the web UI and CLI to not work if log4j.appender.oozie.layout.ConversionPattern in log4j.properties contains a "-" (dash).
> We should try to remove this restriction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-999) XLogStreamer requires
log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or
streaming logs to web UI and CLI don't work
Posted by "Robert Kanter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Kanter updated OOZIE-999:
--------------------------------
Attachment: OOZIE-999.patch
The patch removes the dash and adds a test to verify that it still works.
> XLogStreamer requires log4j.appender.oozie.layout.ConversionPattern to contain a "-" (dash) or streaming logs to web UI and CLI don't work
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-999
> URL: https://issues.apache.org/jira/browse/OOZIE-999
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Fix For: trunk
>
> Attachments: OOZIE-999.patch
>
>
> XLogStreamer.constructPattern() contains:
> {code}
> StringBuilder sb = new StringBuilder();
> if (noFilter) {
> sb.append("(.*)");
> }
> else {
> sb.append("(.* - "); // <----- Here's the dash
> for (int i = 0; i < parameters.size(); i++) {
> sb.append(parameters.get(i) + "\\[");
> sb.append(filterParams.get(parameters.get(i)) + "\\] ");
> }
> sb.append(".*)");
> }
> filterPattern = Pattern.compile(sb.toString());
> {code}
> which causes streaming logs to the web UI and CLI to not work if log4j.appender.oozie.layout.ConversionPattern in log4j.properties contains a "-" (dash).
> We should try to remove this restriction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira