[kudu-CR] Change order of operations during InitCatalogManagerTask

["Ádám Bakai (Code Review)" <ge...@cloudera.org>]

Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19639 )

Change subject: Change order of operations during InitCatalogManagerTask
......................................................................


Patch Set 5:

> > Patch Set 4:
 > >
 > > > Thanks for addressing this. Is this a part of the flaky test
 > >  > failures? Was the fix re-run with dist-test and did we see any
 > >  > further flakiness?
 > >
 > > It's not part of the flaky tests My idea is that it's pretty sure
 > that this change itself won't introduce new flakiness, and
 > dist-test will check if it breaks any test.
 > 
 > Didn't the previous behavior cause a flaky test? How did this
 > problem manifest if not by a flaky test?

Sorry, I meant like it's not part of the flaky test list. It happens rarely. It can be reproduced on my development environment by adding a sleep like this:
master.cc:392
  catalog_manager_init_status_.Set(s);
  SleepFor(MonoDelta::FromMilliseconds(10));
  startup_path_handler_->initialize_master_catalog_progress()->Stop();


-- 
To view, visit http://gerrit.cloudera.org:8080/19639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64c980a8b357c99d4431a02d58b3c03a60bae1ad
Gerrit-Change-Number: 19639
Gerrit-PatchSet: 5
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Aug 2023 15:18:19 +0000
Gerrit-HasComments: No