[GitHub] [iceberg] rdblue commented on a change in pull request #1537: API: Add name to Table and Catalog APIs

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1537:
URL: https://github.com/apache/iceberg/pull/1537#discussion_r497978595



##########
File path: core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java
##########
@@ -129,16 +129,16 @@ public TableBuilder buildTable(TableIdentifier identifier, Schema schema) {
   }
 
   private Table loadMetadataTable(TableIdentifier identifier) {
-    String name = identifier.name();
-    MetadataTableType type = MetadataTableType.from(name);
+    String tableName = identifier.name();
+    MetadataTableType type = MetadataTableType.from(tableName);

Review comment:
       Why rename this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org