You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/01/03 12:15:06 UTC

[native-toolchain-CR] Correct Boost version for Thrift building

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14949 )

Change subject: Correct Boost version for Thrift building
......................................................................


Patch Set 1:

I think we probably need to test this with Impala on x86-64 first to make sure that it doesn't break anything - I don't know if there are any compatibility issues if thrift is compiled with a different boost version from Impala (we might be better off bumping the boost version anyway, which also requries running tests).

I'm currently on vacation and can do this when I get back - otherwise maybe someone else can take a look.


-- 
To view, visit http://gerrit.cloudera.org:8080/14949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a9beb1769e54ce12ab78f0699ae5a2d145e0f7
Gerrit-Change-Number: 14949
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jan 2020 12:15:06 +0000
Gerrit-HasComments: No