You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/04/22 16:17:35 UTC
[GitHub] [dubbo-go-pixiu] lmhmhl opened a new pull request #158: Refractor config_load.go
lmhmhl opened a new pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#discussion_r619730132
##########
File path: pkg/config/config_load.go
##########
@@ -168,22 +185,22 @@ func YAMLConfigLoad(path string) *model.Bootstrap {
}
c.Lb = model.LbPolicy(lbPolicy)
}
-
- return cfg
}
-// DefaultConfigLoad if not config, will load this
-func DefaultConfigLoad(path string) *model.Bootstrap {
- log.Println("load config from : ", path)
- content, err := ioutil.ReadFile(path)
- if err != nil {
- log.Fatalln("[config] [default load] load config failed, ", err)
- }
- cfg := &model.Bootstrap{}
- // translate to lower case
- err = json.Unmarshal(content, cfg)
- if err != nil {
- log.Fatalln("[config] [default load] json unmarshal config failed, ", err)
+func DiscoverType(cfg *model.Bootstrap) {
+ for _, c := range cfg.StaticResources.Clusters {
+ var discoverType int32
Review comment:
u can move this var out of the for-loop scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#issuecomment-826252297
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#158](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dd647b4) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/a16efb1ffe394d42dc8ec0f8b77bf3428d5eacd5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a16efb1) will **increase** coverage by `0.20%`.
> The diff coverage is `48.27%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
+ Coverage 40.60% 40.81% +0.20%
===========================================
Files 35 35
Lines 1692 1698 +6
===========================================
+ Hits 687 693 +6
Misses 903 903
Partials 102 102
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `57.31% <48.27%> (+3.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a16efb1...dd647b4](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#issuecomment-826252297
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#158](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dd647b4) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/a16efb1ffe394d42dc8ec0f8b77bf3428d5eacd5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a16efb1) will **increase** coverage by `0.20%`.
> The diff coverage is `48.27%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
+ Coverage 40.60% 40.81% +0.20%
===========================================
Files 35 35
Lines 1692 1698 +6
===========================================
+ Hits 687 693 +6
Misses 903 903
Partials 102 102
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `57.31% <48.27%> (+3.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a16efb1...dd647b4](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#issuecomment-826252297
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#158](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0083e81) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/a16efb1ffe394d42dc8ec0f8b77bf3428d5eacd5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a16efb1) will **increase** coverage by `0.21%`.
> The diff coverage is `53.70%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
+ Coverage 40.60% 40.82% +0.21%
===========================================
Files 35 35
Lines 1692 1705 +13
===========================================
+ Hits 687 696 +9
+ Misses 903 901 -2
- Partials 102 108 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `56.17% <53.70%> (+2.23%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a16efb1...0083e81](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#discussion_r619830775
##########
File path: pkg/config/config_load.go
##########
@@ -168,22 +183,22 @@ func YAMLConfigLoad(path string) *model.Bootstrap {
}
c.Lb = model.LbPolicy(lbPolicy)
}
-
- return cfg
}
-// DefaultConfigLoad if not config, will load this
-func DefaultConfigLoad(path string) *model.Bootstrap {
- log.Println("load config from : ", path)
- content, err := ioutil.ReadFile(path)
- if err != nil {
- log.Fatalln("[config] [default load] load config failed, ", err)
- }
- cfg := &model.Bootstrap{}
- // translate to lower case
- err = json.Unmarshal(content, cfg)
- if err != nil {
- log.Fatalln("[config] [default load] json unmarshal config failed, ", err)
+func DiscoverType(cfg *model.Bootstrap) {
+ var discoverType int32
+ for _, c := range cfg.StaticResources.Clusters {
+ if c.TypeStr != "" {
+ if t, ok := model.DiscoveryTypeValue[c.TypeStr]; ok {
+ discoverType = t
+ } else {
+ c.TypeStr = "EDS"
+ discoverType = model.DiscoveryTypeValue[c.TypeStr]
+ }
+ } else {
+ c.TypeStr = "EDS"
+ discoverType = model.DiscoveryTypeValue[c.TypeStr]
+ }
Review comment:
```go
flag := false
if c.TypeStr != "" {
if t, ok := model.DiscoveryTypeValue[c.TypeStr]; ok {
discoverType = t
flag = true
}
}
if flag {
c.TypeStr = "EDS"
discoverType = model.DiscoveryTypeValue[c.TypeStr]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#discussion_r619730024
##########
File path: pkg/config/config_load.go
##########
@@ -84,25 +84,53 @@ func YAMLConfigLoad(path string) *model.Bootstrap {
log.Fatalln("[config] [yaml load] load config failed, ", err)
}
cfg := &model.Bootstrap{}
-
bytes, err := yaml.YAMLToJSON(content)
if err != nil {
log.Fatalln("[config] [yaml load] convert YAML to JSON failed, ", err)
}
-
err = json.Unmarshal(bytes, cfg)
if err != nil {
log.Fatalln("[config] [yaml load] yaml unmarshal config failed, ", err)
}
+ adapter(cfg)
+ return cfg
+}
- // other adapter
+// DefaultConfigLoad if not config, will load this
+func DefaultConfigLoad(path string) *model.Bootstrap {
+ log.Println("load config from : ", path)
Review comment:
log.debug?
##########
File path: pkg/config/config_load.go
##########
@@ -168,22 +185,22 @@ func YAMLConfigLoad(path string) *model.Bootstrap {
}
c.Lb = model.LbPolicy(lbPolicy)
}
-
- return cfg
}
-// DefaultConfigLoad if not config, will load this
-func DefaultConfigLoad(path string) *model.Bootstrap {
- log.Println("load config from : ", path)
- content, err := ioutil.ReadFile(path)
- if err != nil {
- log.Fatalln("[config] [default load] load config failed, ", err)
- }
- cfg := &model.Bootstrap{}
- // translate to lower case
- err = json.Unmarshal(content, cfg)
- if err != nil {
- log.Fatalln("[config] [default load] json unmarshal config failed, ", err)
+func DiscoverType(cfg *model.Bootstrap) {
+ for _, c := range cfg.StaticResources.Clusters {
+ var discoverType int32
Review comment:
u can move this var out of the for-loop scope
##########
File path: pkg/config/config_load.go
##########
@@ -168,22 +183,22 @@ func YAMLConfigLoad(path string) *model.Bootstrap {
}
c.Lb = model.LbPolicy(lbPolicy)
}
-
- return cfg
}
-// DefaultConfigLoad if not config, will load this
-func DefaultConfigLoad(path string) *model.Bootstrap {
- log.Println("load config from : ", path)
- content, err := ioutil.ReadFile(path)
- if err != nil {
- log.Fatalln("[config] [default load] load config failed, ", err)
- }
- cfg := &model.Bootstrap{}
- // translate to lower case
- err = json.Unmarshal(content, cfg)
- if err != nil {
- log.Fatalln("[config] [default load] json unmarshal config failed, ", err)
+func DiscoverType(cfg *model.Bootstrap) {
+ var discoverType int32
+ for _, c := range cfg.StaticResources.Clusters {
+ if c.TypeStr != "" {
+ if t, ok := model.DiscoveryTypeValue[c.TypeStr]; ok {
+ discoverType = t
+ } else {
+ c.TypeStr = "EDS"
+ discoverType = model.DiscoveryTypeValue[c.TypeStr]
+ }
+ } else {
+ c.TypeStr = "EDS"
+ discoverType = model.DiscoveryTypeValue[c.TypeStr]
+ }
Review comment:
```go
flag := false
if c.TypeStr != "" {
if t, ok := model.DiscoveryTypeValue[c.TypeStr]; ok {
discoverType = t
flag = true
}
}
if flag {
c.TypeStr = "EDS"
discoverType = model.DiscoveryTypeValue[c.TypeStr]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#issuecomment-826252297
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#158](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ee5177a) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/2173648f31aa3d63c7dcf0aeac5986344994fd52?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2173648) will **increase** coverage by `0.19%`.
> The diff coverage is `53.70%`.
> :exclamation: Current head ee5177a differs from pull request most recent head 2e77f0e. Consider uploading reports for the commit 2e77f0e to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
+ Coverage 42.30% 42.50% +0.19%
===========================================
Files 33 33
Lines 1742 1755 +13
===========================================
+ Hits 737 746 +9
+ Misses 904 902 -2
- Partials 101 107 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `56.17% <53.70%> (+2.23%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2173648...2e77f0e](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#issuecomment-826252297
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#158](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2e77f0e) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/2173648f31aa3d63c7dcf0aeac5986344994fd52?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2173648) will **increase** coverage by `0.19%`.
> The diff coverage is `53.70%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
+ Coverage 42.30% 42.50% +0.19%
===========================================
Files 33 33
Lines 1742 1755 +13
===========================================
+ Hits 737 746 +9
+ Misses 904 902 -2
- Partials 101 107 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `56.17% <53.70%> (+2.23%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2173648...2e77f0e](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#issuecomment-826252297
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#158](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dd647b4) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/a16efb1ffe394d42dc8ec0f8b77bf3428d5eacd5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a16efb1) will **increase** coverage by `0.20%`.
> The diff coverage is `48.27%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
+ Coverage 40.60% 40.81% +0.20%
===========================================
Files 35 35
Lines 1692 1698 +6
===========================================
+ Hits 687 693 +6
Misses 903 903
Partials 102 102
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `57.31% <48.27%> (+3.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a16efb1...dd647b4](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#discussion_r619730024
##########
File path: pkg/config/config_load.go
##########
@@ -84,25 +84,53 @@ func YAMLConfigLoad(path string) *model.Bootstrap {
log.Fatalln("[config] [yaml load] load config failed, ", err)
}
cfg := &model.Bootstrap{}
-
bytes, err := yaml.YAMLToJSON(content)
if err != nil {
log.Fatalln("[config] [yaml load] convert YAML to JSON failed, ", err)
}
-
err = json.Unmarshal(bytes, cfg)
if err != nil {
log.Fatalln("[config] [yaml load] yaml unmarshal config failed, ", err)
}
+ adapter(cfg)
+ return cfg
+}
- // other adapter
+// DefaultConfigLoad if not config, will load this
+func DefaultConfigLoad(path string) *model.Bootstrap {
+ log.Println("load config from : ", path)
Review comment:
log.debug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] xiaoliu10 merged pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
xiaoliu10 merged pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#issuecomment-826252297
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#158](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7361635) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/c016f9eb1302b8e76bd74f5495fdcbb64ce88c23?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c016f9e) will **increase** coverage by `0.19%`.
> The diff coverage is `53.70%`.
> :exclamation: Current head 7361635 differs from pull request most recent head eaae075. Consider uploading reports for the commit eaae075 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
+ Coverage 42.99% 43.19% +0.19%
===========================================
Files 33 33
Lines 1742 1755 +13
===========================================
+ Hits 749 758 +9
+ Misses 890 888 -2
- Partials 103 109 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `56.17% <53.70%> (+2.23%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c016f9e...eaae075](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#issuecomment-826252297
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#158](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eaae075) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/c016f9eb1302b8e76bd74f5495fdcbb64ce88c23?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c016f9e) will **increase** coverage by `0.19%`.
> The diff coverage is `53.70%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
+ Coverage 42.99% 43.19% +0.19%
===========================================
Files 33 33
Lines 1742 1755 +13
===========================================
+ Hits 749 758 +9
+ Misses 890 888 -2
- Partials 103 109 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `56.17% <53.70%> (+2.23%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c016f9e...eaae075](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#issuecomment-826252297
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#158](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dd647b4) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/a16efb1ffe394d42dc8ec0f8b77bf3428d5eacd5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a16efb1) will **increase** coverage by `0.20%`.
> The diff coverage is `48.27%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
+ Coverage 40.60% 40.81% +0.20%
===========================================
Files 35 35
Lines 1692 1698 +6
===========================================
+ Hits 687 693 +6
Misses 903 903
Partials 102 102
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `57.31% <48.27%> (+3.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a16efb1...dd647b4](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#issuecomment-826252297
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#158](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b742f56) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/a16efb1ffe394d42dc8ec0f8b77bf3428d5eacd5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a16efb1) will **increase** coverage by `0.21%`.
> The diff coverage is `53.70%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
+ Coverage 40.60% 40.82% +0.21%
===========================================
Files 35 35
Lines 1692 1705 +13
===========================================
+ Hits 687 696 +9
+ Misses 903 901 -2
- Partials 102 108 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `56.17% <53.70%> (+2.23%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a16efb1...b742f56](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #158: Refractor config_load.go
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#issuecomment-826252297
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#158](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b742f56) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/a16efb1ffe394d42dc8ec0f8b77bf3428d5eacd5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a16efb1) will **increase** coverage by `0.21%`.
> The diff coverage is `53.70%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
+ Coverage 40.60% 40.82% +0.21%
===========================================
Files 35 35
Lines 1692 1705 +13
===========================================
+ Hits 687 696 +9
+ Misses 903 901 -2
- Partials 102 108 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `56.17% <53.70%> (+2.23%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a16efb1...b742f56](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/158?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org