You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@freestoneinfotech.com> on 2016/10/12 13:07:19 UTC

Review Request 52781: RANGER-1170 : Improvement of Unit Test coverage in Ranger (ranger-0.6 branch)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52781/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1170
    https://issues.apache.org/jira/browse/RANGER-1170


Repository: ranger


Description
-------

Update unit test cases related to changePassword and changeEmail api for users having 'keyadmin' or 'user' role


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 32ffef9 
  security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 6c305c4 
  security-admin/src/main/java/org/apache/ranger/rest/UserREST.java 3fad7b4 
  security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 701ec4f 

Diff: https://reviews.apache.org/r/52781/diff/


Testing
-------

**Use Case 1: Change Password API**

1. User having role 'admin' can change his or any other user password.
2. User having role 'keyadmin' or 'user' can change only his password; they should not be able to change any other user password.

**Use Case 2: Change Email API**

1. User having role 'admin' can change his or any other user email.
2. User having role 'keyadmin' or 'user' can change only his email address; they should not be able to change any other user email address.


Thanks,

Pradeep Agrawal


Re: Review Request 52781: RANGER-1170 : Improvement of Unit Test coverage in Ranger (ranger-0.6 branch)

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52781/#review152731
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Oct. 12, 2016, 1:07 p.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52781/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 1:07 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1170
>     https://issues.apache.org/jira/browse/RANGER-1170
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Update unit test cases related to changePassword and changeEmail api for users having 'keyadmin' or 'user' role
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 32ffef9 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 6c305c4 
>   security-admin/src/main/java/org/apache/ranger/rest/UserREST.java 3fad7b4 
>   security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 701ec4f 
> 
> Diff: https://reviews.apache.org/r/52781/diff/
> 
> 
> Testing
> -------
> 
> **Use Case 1: Change Password API**
> 
> 1. User having role 'admin' can change his or any other user password.
> 2. User having role 'keyadmin' or 'user' can change only his password; they should not be able to change any other user password.
> 
> **Use Case 2: Change Email API**
> 
> 1. User having role 'admin' can change his or any other user email.
> 2. User having role 'keyadmin' or 'user' can change only his email address; they should not be able to change any other user email address.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>