[GitHub] [flink] rmetzger commented on a change in pull request #13725: [FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

[GitBox <gi...@apache.org>]

rmetzger commented on a change in pull request #13725:
URL: https://github.com/apache/flink/pull/13725#discussion_r509335808



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/ZooKeeperLeaderRetrievalService.java
##########
@@ -170,7 +174,6 @@ public void nodeChanged() throws Exception {
 					notifyIfNewLeaderAddress(leaderAddress, leaderSessionID);
 				} catch (Exception e) {
 					leaderListener.handleError(new Exception("Could not handle node changed event.", e));
-					throw e;

Review comment:
       I assume the only implication of removing this throw is that curator won't log about the exception anymore, and it won't reset the interrupted flag.
   
   I was wondering for a while if this has any implications, but I assume it is fine to remove, since the leader listener will handle the exception in Flink anyways.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org