You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/06/14 07:45:08 UTC
Review Request 60064: Updated `isAllocatableTo` to use `isSubroleOf`
utility.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60064/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7655
https://issues.apache.org/jira/browse/MESOS-7655
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/common/resources.cpp 7b3fae1a34150964ba3831a3aef2f868e338aef8
src/v1/resources.cpp 236fe17730918479a33314e51d14f3cc1679d432
Diff: https://reviews.apache.org/r/60064/diff/1/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 60064: Updated `isAllocatableTo` to use the
`roles::isSubroleOf` utility.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60064/#review178077
-----------------------------------------------------------
src/common/resources.cpp
Line 920 (original), 920 (patched)
<https://reviews.apache.org/r/60064/#comment251882>
Adjust it as necessary with `isStrictSubroleOf`.
i.e. Add the same role case.
- Michael Park
On June 15, 2017, 12:38 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60064/
> -----------------------------------------------------------
>
> (Updated June 15, 2017, 12:38 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7655
> https://issues.apache.org/jira/browse/MESOS-7655
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch simplifies the `isAllocatableTo` function by leveraging
> the `roles::isSubroleOf` function introduced in
> https://reviews.apache.org/r/60064.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 7b3fae1a34150964ba3831a3aef2f868e338aef8
> src/v1/resources.cpp 236fe17730918479a33314e51d14f3cc1679d432
>
>
> Diff: https://reviews.apache.org/r/60064/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 60064: Updated `isAllocatableTo` to use the
`roles::isSubroleOf` utility.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60064/#review178078
-----------------------------------------------------------
Ship it!
Be sure to adjust to the strict subrole semantics (i.e. you'll have to check the same role case).
- Benjamin Mahler
On June 15, 2017, 7:38 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60064/
> -----------------------------------------------------------
>
> (Updated June 15, 2017, 7:38 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7655
> https://issues.apache.org/jira/browse/MESOS-7655
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch simplifies the `isAllocatableTo` function by leveraging
> the `roles::isSubroleOf` function introduced in
> https://reviews.apache.org/r/60064.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 7b3fae1a34150964ba3831a3aef2f868e338aef8
> src/v1/resources.cpp 236fe17730918479a33314e51d14f3cc1679d432
>
>
> Diff: https://reviews.apache.org/r/60064/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 60064: Updated `isAllocatableTo` to use the
`roles::isSubroleOf` utility.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60064/
-----------------------------------------------------------
(Updated June 15, 2017, 12:38 a.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7655
https://issues.apache.org/jira/browse/MESOS-7655
Repository: mesos
Description (updated)
-------
This patch simplifies the `isAllocatableTo` function by leveraging
the `roles::isSubroleOf` function introduced in
[https://reviews.apache.org/r/60064](r60064).
Diffs
-----
src/common/resources.cpp 7b3fae1a34150964ba3831a3aef2f868e338aef8
src/v1/resources.cpp 236fe17730918479a33314e51d14f3cc1679d432
Diff: https://reviews.apache.org/r/60064/diff/3/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 60064: Updated `isAllocatableTo` to use the
`roles::isSubroleOf` utility.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60064/
-----------------------------------------------------------
(Updated June 15, 2017, 12:37 a.m.)
Review request for mesos and Benjamin Mahler.
Summary (updated)
-----------------
Updated `isAllocatableTo` to use the `roles::isSubroleOf` utility.
Bugs: MESOS-7655
https://issues.apache.org/jira/browse/MESOS-7655
Repository: mesos
Description (updated)
-------
This patch simplifies the `isAllocatableTo` function by leveraging
the `roles::isSubroleOf` function introduced in
[https://reviews.apache.org/r/60064](r60064).
Diffs (updated)
-----
src/common/resources.cpp 7b3fae1a34150964ba3831a3aef2f868e338aef8
src/v1/resources.cpp 236fe17730918479a33314e51d14f3cc1679d432
Diff: https://reviews.apache.org/r/60064/diff/3/
Changes: https://reviews.apache.org/r/60064/diff/2-3/
Testing
-------
`make check`
Thanks,
Michael Park