[jira] [Commented] (KAFKA-5551) StreamThread should not expose methods for testing

["Guozhang Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285529#comment-16285529 ] 

Guozhang Wang commented on KAFKA-5551:
--------------------------------------

I think this is already resolved by {{TaskManager}}?

> StreamThread should not expose methods for testing
> --------------------------------------------------
>
>                 Key: KAFKA-5551
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5551
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>
> {{StreamsThread}} currently exposes {{createStreamTask()}} and {{createStandbyTask()}} as {{protected}} in order to inject "test tasks" in unit tests. We should rework this and make both methods {{private}}. Maybe we can introduce a {{TaskSupplier}} similar to {{KafkaClientSupplier}} (however, {{TaskSupplier}} should not be public API and be in package {{internal}}).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)