You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dajac (via GitHub)" <gi...@apache.org> on 2024/10/30 13:08:12 UTC
[PR] KAFKA-17593; [1/N] Introduce re2j dependency [kafka]
dajac opened a new pull request, #17634:
URL: https://github.com/apache/kafka/pull/17634
This patch is the first of a series of patches to introduce support for server side regular expression. It introduces the re2j dependency.
Co-authored-by: Lianet Magrans <lm...@confluent.io>
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17593; [1/N] Introduce re2j dependency [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #17634:
URL: https://github.com/apache/kafka/pull/17634#issuecomment-2447212630
> Out of curiosity, if I recall correctly, Google's RE2 is not fully compatible with Java regex. Could this cause issues if the `Consumer` accepts Java `Pattern`, allowing users to use unsupported regex features?
That's right. `Pattern` will keep working on the client side via the existing `subscribe(Pattern)` api. We will deprecate it at some point. The server side one will be used via `subscribe(SubscriptionPattern)`. `SubscriptionPattern` is defined [here](https://cwiki.apache.org/confluence/display/KAFKA/KIP-848%3A+The+Next+Generation+of+the+Consumer+Rebalance+Protocol#KIP848:TheNextGenerationoftheConsumerRebalanceProtocol-NewSubscriptionPatternclass). This avoids the compatibility issue but users will have to migrate from the old one to the new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17593; [1/N] Introduce re2j dependency [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #17634:
URL: https://github.com/apache/kafka/pull/17634#issuecomment-2447191336
Out of curiosity, if I recall correctly, Google's RE2 is not fully compatible with Java regex. Could this cause issues if the `Consumer` accepts Java `Pattern`, allowing users to use unsupported regex features?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17593; [1/N] Introduce re2j dependency [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on PR #17634:
URL: https://github.com/apache/kafka/pull/17634#issuecomment-2447095849
We are just missing the lic file right? https://github.com/apache/kafka/blob/898a878c258a022a5cbf4fca5b5e5a1ce56cbc27/licenses/re2j-GO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17593; [1/N] Introduce re2j dependency [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #17634:
URL: https://github.com/apache/kafka/pull/17634#issuecomment-2447115423
@lianetm Good catch! Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17593; [1/N] Introduce re2j dependency [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #17634:
URL: https://github.com/apache/kafka/pull/17634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org