[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #121: [Improvement] Set heartBeatExecutorService as daemon thread

[GitBox <gi...@apache.org>]

smallzhongfeng commented on code in PR #121:
URL: https://github.com/apache/incubator-uniffle/pull/121#discussion_r936632352


##########
client-mr/src/main/java/org/apache/hadoop/mapred/SortWriteBufferManager.java:
##########
@@ -321,7 +321,7 @@ ShuffleBlockInfo createShuffleBlock(SortWriteBuffer wb) {
   }
 
   protected void sendCommit() {
-    ExecutorService executor = Executors.newSingleThreadExecutor();
+    ExecutorService executor = Executors.newSingleThreadExecutor(ThreadUtils.getThreadFactory("bufferManagerSend-%d"));

Review Comment:
   Yes, I think I made a mistake here, but I think a better way would have been to generate this executor at this object initialization. @jerqi The same as below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org