You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/06 17:34:30 UTC

[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36086: [SPARK-38804][PYTHON][SS] Add StreamingQueryManager.removeListener in PySpark

xinrong-databricks commented on code in PR #36086:
URL: https://github.com/apache/spark/pull/36086#discussion_r844211502


##########
python/pyspark/sql/streaming/listener.py:
##########
@@ -95,6 +95,13 @@ def onQueryTerminated(self, event: "QueryTerminatedEvent") -> None:
         """
         pass
 
+    def _set_jlistener(self, jlistener: JavaObject) -> None:
+        """
+        Used to keep the reference of JVM listener instance to be able to remove later viz

Review Comment:
   nit: ... to remove later vi**a**



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org