You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Paul Jungwirth (JIRA)" <ji...@codehaus.org> on 2007/01/22 16:39:16 UTC
[jira] Created: (MASSEMBLY-178) filtering doesn't read filter files
filtering doesn't read filter files
-----------------------------------
Key: MASSEMBLY-178
URL: http://jira.codehaus.org/browse/MASSEMBLY-178
Project: Maven 2.x Assembly Plugin
Issue Type: Bug
Affects Versions: 2.0
Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
Reporter: Paul Jungwirth
Priority: Minor
Attachments: filter-test.tar.gz
The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
homer=woohoo
But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-178) filtering doesn't read filter
files
Posted by "Mark Diggory (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101600 ]
Mark Diggory commented on MASSEMBLY-178:
----------------------------------------
It appears that moduleSets cannot be filtered either.
<pre><code>
<moduleSet>
<includes>
<include>*:war</include>
</includes>
<binaries>
<includeDependencies>false</includeDependencies>
<outputDirectory>webapps/${artifactId}</outputDirectory>
<unpack>true</unpack>
<unpackOptions>
<filtered>true</filtered>
</unpackOptions>
</binaries>
</moduleSet>
</code></pre>
fails on Maven 2.0.7 and Assembly-plugin 2.2-beta-2-SNAPSHOT. I have a web.xml with a ${property} that will not get filtered when I have evidence all other <files> are filtered appropriately.
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Fix For: 2.2-beta-2
>
> Attachments: filt-dist.diff, filter-test.tar.gz, filter-test.zip
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-178) filtering doesn't read filter files
Posted by "Bertrand Fovez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Fovez updated MASSEMBLY-178:
-------------------------------------
Attachment: filter-test.zip
Here is a sample derived from John's one showing that filtering doesn't seem to worok with <fileset> tag, even with the doc fix.
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Attachments: filt-dist.diff, filter-test.tar.gz, filter-test.zip
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-178) filtering doesn't read filter
files
Posted by "John Franey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_88060 ]
John Franey commented on MASSEMBLY-178:
---------------------------------------
The documentation is wrong for versions 2.1 and 2.2-SNAPSHOT. The filters element is really a child of <build> element not the plugin's <configuration>. To be attached is a patch to the documentation.
I got this to work with maven 2.0.4 and versions 2.1 and 2.2-SNAPSHOT of the assembly plugin.
I was unable to use your pom with version 2.0 of the assembly plugin because the goal 'attached' does not apparently exist in that version of the plugin. I guess when you selected 'version' for this issue report, you didn't mean to select 2.0.
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Attachments: filter-test.tar.gz
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MASSEMBLY-178) filtering doesn't read filter files
Posted by "Fabrice BELLINGARD (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fabrice BELLINGARD closed MASSEMBLY-178.
----------------------------------------
Resolution: Fixed
FilSets filtering added (see MASSEMBLY-154)
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Attachments: filt-dist.diff, filter-test.tar.gz, filter-test.zip
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-178) filtering doesn't read filter files
Posted by "Fabrice BELLINGARD (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fabrice BELLINGARD updated MASSEMBLY-178:
-----------------------------------------
Fix Version/s: 2.2-beta-2
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Fix For: 2.2-beta-2
>
> Attachments: filt-dist.diff, filter-test.tar.gz, filter-test.zip
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-178) filtering doesn't read filter
files
Posted by "Paul Jungwirth (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_88066 ]
Paul Jungwirth commented on MASSEMBLY-178:
------------------------------------------
You're right, moving the <filters> block fixed the problem. Thanks!
Sorry I marked this 2.0. I was thinking Maven version (2.0.4), not plugin version.
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Attachments: filt-dist.diff, filter-test.tar.gz
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-178) filtering doesn't read filter
files
Posted by "Fabrice BELLINGARD (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101320 ]
Fabrice BELLINGARD commented on MASSEMBLY-178:
----------------------------------------------
MASSEMBLY-154 added the possibility to filter fileSets.
I tested your example, and with the following assembly descriptor, the filtering works fine:
{code:xml}
<assembly>
<id>bin</id>
<formats>
<format>zip</format>
</formats>
<fileSets>
<fileSet>
<directory>target</directory>
<outputDirectory></outputDirectory>
<includes>
<include>*.jar</include>
</includes>
</fileSet>
<fileSet>
<directory>${basedir}</directory>
<outputDirectory>/</outputDirectory>
<includes>
<include>README</include>
</includes>
<filtered>true</filtered>
</fileSet>
</fileSets>
</assembly>
{code}
Please note that I had to specify "${basedir}" for the <directory> of the 2nd fileSet to make it work. In your first assembly descriptor, a "/" was used instead, which prevented the README file from being filtered.
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Attachments: filt-dist.diff, filter-test.tar.gz, filter-test.zip
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MASSEMBLY-178) filtering doesn't read
filter files
Posted by "Mark Diggory (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101600 ]
Mark Diggory edited comment on MASSEMBLY-178 at 7/7/07 4:37 PM:
----------------------------------------------------------------
It appears that moduleSets cannot be filtered either.
<moduleSet>
<includes>
<include>*:war</include>
</includes>
<binaries>
<includeDependencies>false</includeDependencies>
<outputDirectory>webapps/${artifactId}</outputDirectory>
<unpack>true</unpack>
<unpackOptions>
<filtered>true</filtered>
</unpackOptions>
</binaries>
</moduleSet>
fails on Maven 2.0.7 and Assembly-plugin 2.2-beta-2-SNAPSHOT. I have a web.xml with a ${property} that will not get filtered when I have evidence all other <files> are filtered appropriately.
was:
It appears that moduleSets cannot be filtered either.
<pre><code>
<moduleSet>
<includes>
<include>*:war</include>
</includes>
<binaries>
<includeDependencies>false</includeDependencies>
<outputDirectory>webapps/${artifactId}</outputDirectory>
<unpack>true</unpack>
<unpackOptions>
<filtered>true</filtered>
</unpackOptions>
</binaries>
</moduleSet>
</code></pre>
fails on Maven 2.0.7 and Assembly-plugin 2.2-beta-2-SNAPSHOT. I have a web.xml with a ${property} that will not get filtered when I have evidence all other <files> are filtered appropriately.
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Fix For: 2.2-beta-2
>
> Attachments: filt-dist.diff, filter-test.tar.gz, filter-test.zip
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-178) filtering doesn't read filter
files
Posted by "Christophe Domas (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_95562 ]
Christophe Domas commented on MASSEMBLY-178:
--------------------------------------------
The assembly descriptor documentation (http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html) says that it's possible to filter fileSets:
<fileSets>
<fileSet>
<directory/>
<lineEnding/>
<filtered/>
<useStrictFiltering/>
<useDefaultExcludes/>
<outputDirectory/>
<includes/>
<excludes/>
<fileMode/>
<directoryMode/>
</fileSet>
</fileSets>
<files>
<file>
<source/>
<outputDirectory/>
<destName/>
<fileMode/>
<lineEnding/>
<filtered/>
</file>
</files>
but it doesn't work with version 2.2-beta1. Could you fix it? I would prefer that you fix the code more than the doc ;-)
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Attachments: filt-dist.diff, filter-test.tar.gz, filter-test.zip
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-178) filtering doesn't read filter
files
Posted by "Bertrand Fovez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101440 ]
Bertrand Fovez commented on MASSEMBLY-178:
------------------------------------------
Hello,
However, the following, based upon the previous, doesn't work :
<assembly>
<id>bin</id>
<formats>
<format>zip</format>
</formats>
<fileSets>
<fileSet>
<directory>${basedir}/../poms/assembly/boot</directory>
<outputDirectory>/</outputDirectory>
<includes>
<include>README</include>
</includes>
<filtered>true</filtered>
</fileSet>
</fileSets>
</assembly>
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Fix For: 2.2-beta-2
>
> Attachments: filt-dist.diff, filter-test.tar.gz, filter-test.zip
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MASSEMBLY-178) filtering doesn't read
filter files
Posted by "Bertrand Fovez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101440 ]
Bertrand Fovez edited comment on MASSEMBLY-178 at 7/6/07 4:03 AM:
------------------------------------------------------------------
Hello,
However, the following, based upon the previous, doesn't work :
{noformat}
<assembly>
<id>bin</id>
<formats>
<format>zip</format>
</formats>
<fileSets>
<fileSet>
<directory>${basedir}/../poms/assembly/boot</directory>
<outputDirectory>/</outputDirectory>
<includes>
<include>README</include>
</includes>
<filtered>true</filtered>
</fileSet>
</fileSets>
</assembly>
{noformat}
was:
Hello,
However, the following, based upon the previous, doesn't work :
<assembly>
<id>bin</id>
<formats>
<format>zip</format>
</formats>
<fileSets>
<fileSet>
<directory>${basedir}/../poms/assembly/boot</directory>
<outputDirectory>/</outputDirectory>
<includes>
<include>README</include>
</includes>
<filtered>true</filtered>
</fileSet>
</fileSets>
</assembly>
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Fix For: 2.2-beta-2
>
> Attachments: filt-dist.diff, filter-test.tar.gz, filter-test.zip
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MASSEMBLY-178) filtering doesn't read
filter files
Posted by "Mark Diggory (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101600 ]
Mark Diggory edited comment on MASSEMBLY-178 at 7/7/07 4:38 PM:
----------------------------------------------------------------
It appears that moduleSets cannot be filtered either.
<code>
<moduleSet>
<includes>
<include>*:war</include>
</includes>
<binaries>
<includeDependencies>false</includeDependencies>
<outputDirectory>webapps/${artifactId}</outputDirectory>
<unpack>true</unpack>
<unpackOptions>
<filtered>true</filtered>
</unpackOptions>
</binaries>
</moduleSet>
</code>
fails on Maven 2.0.7 and Assembly-plugin 2.2-beta-2-SNAPSHOT. I have a web.xml with a ${property} that will not get filtered when I have evidence all other <files> are filtered appropriately.
was:
It appears that moduleSets cannot be filtered either.
<moduleSet>
<includes>
<include>*:war</include>
</includes>
<binaries>
<includeDependencies>false</includeDependencies>
<outputDirectory>webapps/${artifactId}</outputDirectory>
<unpack>true</unpack>
<unpackOptions>
<filtered>true</filtered>
</unpackOptions>
</binaries>
</moduleSet>
fails on Maven 2.0.7 and Assembly-plugin 2.2-beta-2-SNAPSHOT. I have a web.xml with a ${property} that will not get filtered when I have evidence all other <files> are filtered appropriately.
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Fix For: 2.2-beta-2
>
> Attachments: filt-dist.diff, filter-test.tar.gz, filter-test.zip
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MASSEMBLY-178) filtering doesn't read
filter files
Posted by "Mark Diggory (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101600 ]
Mark Diggory edited comment on MASSEMBLY-178 at 7/7/07 4:40 PM:
----------------------------------------------------------------
It appears that moduleSets cannot be filtered either.
{code:xml}
<moduleSet>
<includes>
<include>*:war</include>
</includes>
<binaries>
<includeDependencies>false</includeDependencies>
<outputDirectory>webapps/${artifactId}</outputDirectory>
<unpack>true</unpack>
<unpackOptions>
<filtered>true</filtered>
</unpackOptions>
</binaries>
</moduleSet>
{code}
fails on Maven 2.0.7 and Assembly-plugin 2.2-beta-2-SNAPSHOT. I have a web.xml with a ${property} that will not get filtered when I have evidence all other <files> are filtered appropriately.
was:
It appears that moduleSets cannot be filtered either.
<code>
<moduleSet>
<includes>
<include>*:war</include>
</includes>
<binaries>
<includeDependencies>false</includeDependencies>
<outputDirectory>webapps/${artifactId}</outputDirectory>
<unpack>true</unpack>
<unpackOptions>
<filtered>true</filtered>
</unpackOptions>
</binaries>
</moduleSet>
</code>
fails on Maven 2.0.7 and Assembly-plugin 2.2-beta-2-SNAPSHOT. I have a web.xml with a ${property} that will not get filtered when I have evidence all other <files> are filtered appropriately.
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Fix For: 2.2-beta-2
>
> Attachments: filt-dist.diff, filter-test.tar.gz, filter-test.zip
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-178) filtering doesn't read filter
files
Posted by "Bertrand Fovez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_93832 ]
Bertrand Fovez commented on MASSEMBLY-178:
------------------------------------------
Hello,
The fix works fine, indeed, for the <file> tag. I tried with the <fileset> tag and it doesn't seem to work in this case.
I tested with Maven 2.0.6 and Assembly plug-in 2.2-beta-1.
I attached an sample derived from John's one.
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Attachments: filt-dist.diff, filter-test.tar.gz
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-178) filtering doesn't read filter files
Posted by "John Franey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Franey updated MASSEMBLY-178:
----------------------------------
Attachment: filt-dist.diff
Correcting the example to show the filter is a child of build element, not a child of the assembly plugin's configuration element.
> filtering doesn't read filter files
> -----------------------------------
>
> Key: MASSEMBLY-178
> URL: http://jira.codehaus.org/browse/MASSEMBLY-178
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.0
> Environment: Linux icebox 2.6.17-1.2174_FC5 #1 Tue Aug 8 15:30:55 EDT 2006 i686 athlon i386 GNU/Linux
> Reporter: Paul Jungwirth
> Priority: Minor
> Attachments: filt-dist.diff, filter-test.tar.gz
>
>
> The assembly plugin's filtering supports POM properties like ${project.artifactId}, but not properties read from the filter file, contrary to the documentation here:
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/single/filtering-some-distribution-files.html
> I've attached a sample app demonstrating the problem. You can run it by saying "mvn clean package." It tries to filter a README file with both ${project.artifactId} and ${homer}. ${homer} is defined in filter.properties like this:
> homer=woohoo
> But when you run the plugin, only ${project.artifactId} is filtered.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira