You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/04/12 01:56:51 UTC
[jira] Updated: (MPASPECTJ-8) Weaving classes not jars, and many other features
The following issue has been updated:
Updater: Carlos Sanchez (mailto:apache@carlos.cousas.net)
Date: Sun, 11 Apr 2004 7:55 PM
Changes:
Attachment changed to maven-aspectj-plugin-3.0.patch
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPASPECTJ-8&page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPASPECTJ-8
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPASPECTJ-8
Summary: Weaving classes not jars, and many other features
Type: New Feature
Status: Unassigned
Priority: Major
Original Estimate: 5 minutes
Time Spent: Unknown
Remaining: 5 minutes
Project: maven-aspectj-plugin
Versions:
2.0
Assignee:
Reporter: Carlos Sanchez
Created: Sun, 11 Apr 2004 7:54 PM
Updated: Sun, 11 Apr 2004 7:55 PM
Environment: Maven 1.0-rc1
AspectJ 1.1.1
Description:
Ability to automatically weave aspects on the classes generated on java:compile
Ability to add dependencies on libraries with aspects.
Proposed new way to reuse aspects as done in ejb, cactus and war plugins
<dependency>
<groupId>groupid</groupId>
<artifactId>jarid</artifactId>
<version>jarversion</version>
<properties>
<aspectj.weave>true</aspectj.weave>
</properties>
</dependency>
although maintaining old way.
Also added installation of jar and snapshot with reusable aspects but not needed with this new way to define dependencies.
Updated and improved documentation, check it for more info, also in http://oness.sourceforge.net/maven-aspectj-plugin
(I've called it version 3.0)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [jira] Updated: (MPASPECTJ-8) Weaving classes not jars, and many other features
Posted by Carlos Sanchez <ap...@carlos.cousas.net>.
Hi Vincent,
Thanks for the compliments.
About autoweave the only anoying thing would be the downloading of aspectj
jars, it's a thing I haven't thought about.
If you prefer not to include it I agree.
I've just uploaded the patch for changes.xml
> -----Mensaje original-----
> De: Vincent Massol [mailto:vmassol@pivolis.com]
> Enviado el: lunes, 12 de abril de 2004 19:44
> Para: 'Maven Developers List'
> CC: apache@carlos.cousas.net
> Asunto: RE: [jira] Updated: (MPASPECTJ-8) Weaving classes not
> jars, and many other features
>
> Hi Carlos,
>
> Good patch! Still reading it before applying it. Could you
> please provide a patch for changes.xml too?
>
> I know I was the one who first started this but I think we
> should remove any preGoal/postGoal from the AspectJ plugin.
> Actually, I believe there should not be any of them in any
> Maven plugins. The reasons are:
>
> - they should be left for end users
> - there is no guaranteed order of execution of different
> preGoal/postGoals
> - people not using aspects will see goals like aspectj:init
> executing in their environment and aspectj jars will get downloaded...
>
> So I think we should drop the autoweave feature.
>
> What do you think? What do others think?
>
> Thanks
> -Vincent
>
> > -----Original Message-----
> > From: jira@codehaus.org [mailto:jira@codehaus.org]
> > Sent: 12 April 2004 01:57
> > To: dev@maven.apache.org
> > Subject: [jira] Updated: (MPASPECTJ-8) Weaving classes not jars, and
> many
> > other features
> >
> > The following issue has been updated:
> >
> > Updater: Carlos Sanchez (mailto:apache@carlos.cousas.net)
> > Date: Sun, 11 Apr 2004 7:55 PM
> > Changes:
> > Attachment changed to maven-aspectj-plugin-3.0.patch
> >
> ---------------------------------------------------------------------
> > For a full history of the issue, see:
> >
> > http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPASPECTJ-
> > 8&page=history
> >
> >
> ---------------------------------------------------------------------
> > View the issue:
> > http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPASPECTJ-8
> >
> > Here is an overview of the issue:
> >
> ---------------------------------------------------------------------
> > Key: MPASPECTJ-8
> > Summary: Weaving classes not jars, and many other features
> > Type: New Feature
> >
> > Status: Unassigned
> > Priority: Major
> >
> > Original Estimate: 5 minutes
> > Time Spent: Unknown
> > Remaining: 5 minutes
> >
> > Project: maven-aspectj-plugin
> > Versions:
> > 2.0
> >
> > Assignee:
> > Reporter: Carlos Sanchez
> >
> > Created: Sun, 11 Apr 2004 7:54 PM
> > Updated: Sun, 11 Apr 2004 7:55 PM
> > Environment: Maven 1.0-rc1
> > AspectJ 1.1.1
> >
> > Description:
> > Ability to automatically weave aspects on the classes generated on
> > java:compile Ability to add dependencies on libraries with aspects.
> >
> > Proposed new way to reuse aspects as done in ejb, cactus and war
> plugins
> >
> > <dependency>
> > <groupId>groupid</groupId>
> > <artifactId>jarid</artifactId>
> > <version>jarversion</version>
> > <properties>
> > <aspectj.weave>true</aspectj.weave>
> > </properties>
> > </dependency>
> >
> > although maintaining old way.
> >
> > Also added installation of jar and snapshot with reusable
> aspects but
> not
> > needed with this new way to define dependencies.
> >
> > Updated and improved documentation, check it for more info, also in
> > http://oness.sourceforge.net/maven-aspectj-plugin
> >
> > (I've called it version 3.0)
> >
> >
> >
> >
> ---------------------------------------------------------------------
> > JIRA INFORMATION:
> > This message is automatically generated by JIRA.
> >
> > If you think it was sent incorrectly contact one of the
> administrators:
> > http://jira.codehaus.org/secure/Administrators.jspa
> >
> > If you want more information on JIRA, or have a bug to report see:
> > http://www.atlassian.com/software/jira
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
> > additional commands, e-mail: dev-help@maven.apache.org
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [jira] Updated: (MPASPECTJ-8) Weaving classes not jars, and many other features
Posted by Vincent Massol <vm...@pivolis.com>.
Hi Carlos,
Good patch! Still reading it before applying it. Could you please
provide a patch for changes.xml too?
I know I was the one who first started this but I think we should remove
any preGoal/postGoal from the AspectJ plugin. Actually, I believe there
should not be any of them in any Maven plugins. The reasons are:
- they should be left for end users
- there is no guaranteed order of execution of different
preGoal/postGoals
- people not using aspects will see goals like aspectj:init executing in
their environment and aspectj jars will get downloaded...
So I think we should drop the autoweave feature.
What do you think? What do others think?
Thanks
-Vincent
> -----Original Message-----
> From: jira@codehaus.org [mailto:jira@codehaus.org]
> Sent: 12 April 2004 01:57
> To: dev@maven.apache.org
> Subject: [jira] Updated: (MPASPECTJ-8) Weaving classes not jars, and
many
> other features
>
> The following issue has been updated:
>
> Updater: Carlos Sanchez (mailto:apache@carlos.cousas.net)
> Date: Sun, 11 Apr 2004 7:55 PM
> Changes:
> Attachment changed to maven-aspectj-plugin-3.0.patch
>
---------------------------------------------------------------------
> For a full history of the issue, see:
>
> http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPASPECTJ-
> 8&page=history
>
> ---------------------------------------------------------------------
> View the issue:
> http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPASPECTJ-8
>
> Here is an overview of the issue:
> ---------------------------------------------------------------------
> Key: MPASPECTJ-8
> Summary: Weaving classes not jars, and many other features
> Type: New Feature
>
> Status: Unassigned
> Priority: Major
>
> Original Estimate: 5 minutes
> Time Spent: Unknown
> Remaining: 5 minutes
>
> Project: maven-aspectj-plugin
> Versions:
> 2.0
>
> Assignee:
> Reporter: Carlos Sanchez
>
> Created: Sun, 11 Apr 2004 7:54 PM
> Updated: Sun, 11 Apr 2004 7:55 PM
> Environment: Maven 1.0-rc1
> AspectJ 1.1.1
>
> Description:
> Ability to automatically weave aspects on the classes generated on
> java:compile
> Ability to add dependencies on libraries with aspects.
>
> Proposed new way to reuse aspects as done in ejb, cactus and war
plugins
>
> <dependency>
> <groupId>groupid</groupId>
> <artifactId>jarid</artifactId>
> <version>jarversion</version>
> <properties>
> <aspectj.weave>true</aspectj.weave>
> </properties>
> </dependency>
>
> although maintaining old way.
>
> Also added installation of jar and snapshot with reusable aspects but
not
> needed with this new way to define dependencies.
>
> Updated and improved documentation, check it for more info, also in
> http://oness.sourceforge.net/maven-aspectj-plugin
>
> (I've called it version 3.0)
>
>
>
> ---------------------------------------------------------------------
> JIRA INFORMATION:
> This message is automatically generated by JIRA.
>
> If you think it was sent incorrectly contact one of the
administrators:
> http://jira.codehaus.org/secure/Administrators.jspa
>
> If you want more information on JIRA, or have a bug to report see:
> http://www.atlassian.com/software/jira
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org