You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2019/03/21 22:42:38 UTC
[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12829
Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress
......................................................................
IMPALA-8202: Add more logging to TestAdmissionControllerStress
This change adds some logging and fixes a bug where the string
match that identified a timeout was wrong. The added logging
would provide more information about the state to help diagnose
root cause for IMPALA-8202.
Change-Id: Ib62cefac0dc53da0a9f26fdd959975deafc70c8f
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/12829/1
--
To view, visit http://gerrit.cloudera.org:8080/12829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib62cefac0dc53da0a9f26fdd959975deafc70c8f
Gerrit-Change-Number: 12829
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12829 )
Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2513/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib62cefac0dc53da0a9f26fdd959975deafc70c8f
Gerrit-Change-Number: 12829
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 23:17:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12829 )
Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib62cefac0dc53da0a9f26fdd959975deafc70c8f
Gerrit-Change-Number: 12829
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 05:00:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12829 )
Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib62cefac0dc53da0a9f26fdd959975deafc70c8f
Gerrit-Change-Number: 12829
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 00:29:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12829 )
Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress
......................................................................
IMPALA-8202: Add more logging to TestAdmissionControllerStress
This change adds some logging and fixes a bug where the string
match that identified a timeout was wrong. The added logging
would provide more information about the state to help diagnose
root cause for IMPALA-8202.
Change-Id: Ib62cefac0dc53da0a9f26fdd959975deafc70c8f
Reviewed-on: http://gerrit.cloudera.org:8080/12829
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib62cefac0dc53da0a9f26fdd959975deafc70c8f
Gerrit-Change-Number: 12829
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12829 )
Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib62cefac0dc53da0a9f26fdd959975deafc70c8f
Gerrit-Change-Number: 12829
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 00:22:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12829 )
Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3943/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib62cefac0dc53da0a9f26fdd959975deafc70c8f
Gerrit-Change-Number: 12829
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 00:29:50 +0000
Gerrit-HasComments: No