[jira] Closed: (COLLECTIONS-255) Unused variable in TreeBidiMap.java

["Henri Yandell (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/COLLECTIONS-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed COLLECTIONS-255.
-------------------------------------

    Resolution: Fixed

svn ci -m "Removing the unused variable as mentioned in COLLECTIONS-255 by caching the TreeView object" src

Sending        src/java/org/apache/commons/collections/bidimap/TreeBidiMap.java
Transmitting file data .
Committed revision 575154.

> Unused variable in TreeBidiMap.java
> -----------------------------------
>
>                 Key: COLLECTIONS-255
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-255
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: BidiMap
>    Affects Versions: Nightly Builds
>            Reporter: Henri Yandell
>            Assignee: Henri Yandell
>            Priority: Trivial
>             Fix For: 3.3
>
>         Attachments: COLLECTIONS-255.patch
>
>
> Twice in TreeBidiMap there is an entrySet variable that is not used. Rather the entrySet() method returns a new TreeView every time.
> We should either:
> a) Delete the variable.
> b) Use the variable and always return the same TreeView.
> I'm thinking a).
> [Found via http://opensource.fortifysoftware.com/ ]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.