You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/04 17:08:53 UTC

[GitHub] [incubator-nuttx] yamt opened a new pull request #968: Surpress macOS AR warnings differently

yamt opened a new pull request #968:
URL: https://github.com/apache/incubator-nuttx/pull/968


   ## Summary
   Use a wrapper script to remove warnings instead of injecting dummy symbols to every objects
   ## Impact
   macOS sim
   ## Testing
   I built sim:spiffs config locally
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #968: Surpress macOS AR warnings differently

Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #968:
URL: https://github.com/apache/incubator-nuttx/pull/968#discussion_r420093380



##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -69,10 +64,11 @@ CPP = $(CROSSDEV)cc -E -P -x c
 LD = $(CROSSDEV)ld
 ifeq ($(CONFIG_HOST_MACOS),y)
 STRIP = $(CROSSDEV)strip
+AR = $(TOPDIR)/tools/xcode-silent-ar-rcs

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #968: Surpress macOS AR warnings differently

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #968:
URL: https://github.com/apache/incubator-nuttx/pull/968#discussion_r420082619



##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -69,10 +64,11 @@ CPP = $(CROSSDEV)cc -E -P -x c
 LD = $(CROSSDEV)ld
 ifeq ($(CONFIG_HOST_MACOS),y)
 STRIP = $(CROSSDEV)strip
+AR = $(TOPDIR)/tools/xcode-silent-ar-rcs

Review comment:
       Fine with me




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #968: Surpress macOS AR warnings differently

Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #968:
URL: https://github.com/apache/incubator-nuttx/pull/968#discussion_r420081460



##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -69,10 +64,11 @@ CPP = $(CROSSDEV)cc -E -P -x c
 LD = $(CROSSDEV)ld
 ifeq ($(CONFIG_HOST_MACOS),y)
 STRIP = $(CROSSDEV)strip
+AR = $(TOPDIR)/tools/xcode-silent-ar-rcs

Review comment:
       how about macar-rcs.sh then?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #968: Surpress macOS AR warnings differently

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #968:
URL: https://github.com/apache/incubator-nuttx/pull/968#discussion_r419684049



##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -69,10 +64,11 @@ CPP = $(CROSSDEV)cc -E -P -x c
 LD = $(CROSSDEV)ld
 ifeq ($(CONFIG_HOST_MACOS),y)
 STRIP = $(CROSSDEV)strip
+AR = $(TOPDIR)/tools/xcode-silent-ar-rcs

Review comment:
       Should we give the new file .sh suffix?
   Change to macar like zdsar?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org