You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/29 06:34:33 UTC
[GitHub] [arrow-datafusion] yahoNanJing opened a new issue, #3651: Change *ExecutionPlan* from trait to enum similar as *LogicalPlan*
yahoNanJing opened a new issue, #3651:
URL: https://github.com/apache/arrow-datafusion/issues/3651
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, in addition to the *what*) -->
As #2175 mentioned, if we still keep *ExecutionPlan* as a trait, its related trait object usage will cause many limitations, like not feasible to return Self, inconvenience pattern matching, etc.
**Describe the solution you'd like**
<!-- A clear and concise description of what you want to happen. -->
It's better to change the *ExecutionPlan* from trait to enum similar as *LogicalPlan*. For the extension of execution plan, we can introduce a trait for that to provide some extent flexibility, like
```
enum ExecutionPlan {
...
Extension {
extension: Arc<dyn ExecutionPlanExtension>,
}
...
```
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
Add any other context or screenshots about the feature request here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #3651: Change *ExecutionPlan* from trait to enum similar as *LogicalPlan*
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3651:
URL: https://github.com/apache/arrow-datafusion/issues/3651#issuecomment-1262598716
See also @tustvold 's comments on https://github.com/apache/arrow-datafusion/issues/2175#issuecomment-1262554350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on issue #3651: Change *ExecutionPlan* from trait to enum similar as *LogicalPlan*
Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #3651:
URL: https://github.com/apache/arrow-datafusion/issues/3651#issuecomment-1264379810
Rather than changing ExectionPlan to be an enum, why don't we add a new enum that can wrap ExecutionPlan? See https://github.com/apache/arrow-datafusion/pull/3677 for my proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #3651: Change *ExecutionPlan* from trait to enum similar as *LogicalPlan*
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3651:
URL: https://github.com/apache/arrow-datafusion/issues/3651#issuecomment-1262125648
We might want to send a note to the email list and slack channel to let people know of this change. It is likely to cause significant code churn in all downstream projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org