You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by GitBox <gi...@apache.org> on 2019/01/14 12:02:55 UTC

[GitHub] franz1981 commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

franz1981 commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks
URL: https://github.com/apache/activemq-artemis/pull/2250#issuecomment-453982469
 
 
   @CNNJYB Paging (write side) is using thread pool provided by file factory, while this PR is enforcing creation of a single direct ByteBuffer to be used for all the files to be compacted. 
   Compaction doesn't need to start fast while paging yes: I'm not sure that it will bring the same value on paging, but if you have an idea please share it... 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services