You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "wForget (via GitHub)" <gi...@apache.org> on 2025/03/17 09:26:32 UTC

[PR] [DNM][GLUTEN-9027] Check artifact files found for build native lib job [incubator-gluten]

wForget opened a new pull request, #9028:
URL: https://github.com/apache/incubator-gluten/pull/9028

   ## What changes were proposed in this pull request?
   
   Check artifact files found for build native lib job
   
   Fixes: #9027
   
   ## How was this patch tested?
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9027][VL] Check artifact files found for build native lib job [incubator-gluten]

Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget commented on PR #9028:
URL: https://github.com/apache/incubator-gluten/pull/9028#issuecomment-2732133380

   > I also note this issue. I am still wondering why this CI job is not red when the script fails to build gluten native code, even though `set -e` is already set in the script. Do you know the reason?
   
   Seems like it's due to building in docker?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [DNM][GLUTEN-9027] Check artifact files found for build native lib job [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9028:
URL: https://github.com/apache/incubator-gluten/pull/9028#issuecomment-2728758340

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICEGJ-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on Github Issues?
   
   https://github.com/apache/incubator-gluten/issues
   
   Then could you also rename ***commit message*** and ***pull request title*** in the following format?
   
       [GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9027][VL] Check artifact files found for build native lib job [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9028:
URL: https://github.com/apache/incubator-gluten/pull/9028#issuecomment-2731489453

   https://github.com/apache/incubator-gluten/issues/9027


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [DNM][GLUTEN-9027][VL] Check artifact files found for build native lib job [incubator-gluten]

Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget commented on code in PR #9028:
URL: https://github.com/apache/incubator-gluten/pull/9028#discussion_r1998463934


##########
.github/workflows/velox_backend.yml:
##########
@@ -105,11 +105,15 @@ jobs:
       - uses: actions/upload-artifact@v4
         with:
           name: velox-native-lib-centos-7-${{github.sha}}
-          path: ./cpp/build/releases/
+          path: ｜
+            ./cpp/build/releases/libgluten.*

Review Comment:
   This job will fail if the artifact files do not exist. 
   
   https://github.com/apache/incubator-gluten/actions/runs/13897311029/job/38880793037?pr=9028



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9027][VL] Check artifact files found for build native lib job [incubator-gluten]

Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget commented on code in PR #9028:
URL: https://github.com/apache/incubator-gluten/pull/9028#discussion_r2000578606


##########
.github/workflows/velox_backend.yml:
##########
@@ -85,6 +85,7 @@ jobs:
         run: |
           docker pull apache/gluten:vcpkg-centos-7
           docker run -v $GITHUB_WORKSPACE:/work -w /work apache/gluten:vcpkg-centos-7 bash -c "
+            set -e

Review Comment:
   > @wForget, great! Please remove useless changes. Thanks!
   
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9027][VL] Check artifact files found for build native lib job [incubator-gluten]

Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #9028:
URL: https://github.com/apache/incubator-gluten/pull/9028#issuecomment-2732106609

   I also note this issue. I am wondering why this CI job is not red when the script fails to build gluten native code, even though `set -e` is already set in the script. Do you know the reason?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [DNM][GLUTEN-9027][VL] Check artifact files found for build native lib job [incubator-gluten]

Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget commented on code in PR #9028:
URL: https://github.com/apache/incubator-gluten/pull/9028#discussion_r1998463934


##########
.github/workflows/velox_backend.yml:
##########
@@ -105,11 +105,15 @@ jobs:
       - uses: actions/upload-artifact@v4
         with:
           name: velox-native-lib-centos-7-${{github.sha}}
-          path: ./cpp/build/releases/
+          path: ｜
+            ./cpp/build/releases/libgluten.*

Review Comment:
   This job will fail if the artifact files do not exist. 
   
   https://github.com/apache/incubator-gluten/actions/runs/13897311029/job/38880793037?pr=9028



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [DNM][GLUTEN-9027][VL] Check artifact files found for build native lib job [incubator-gluten]

Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget commented on code in PR #9028:
URL: https://github.com/apache/incubator-gluten/pull/9028#discussion_r2000095738


##########
.github/workflows/velox_backend.yml:
##########
@@ -95,7 +95,15 @@ jobs:
             mkdir -p /work/.m2/repository/org/apache/arrow/
             cp -r /root/.m2/repository/org/apache/arrow/* /work/.m2/repository/org/apache/arrow/
           "
-
+          # check release files

Review Comment:
   This job will fail when velox or gluten build fails, see: https://github.com/apache/incubator-gluten/actions/runs/13914275514/job/38934362713?pr=9028



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9027][VL] Check artifact files found for build native lib job [incubator-gluten]

Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget commented on code in PR #9028:
URL: https://github.com/apache/incubator-gluten/pull/9028#discussion_r2000568351


##########
.github/workflows/velox_backend.yml:
##########
@@ -85,6 +85,7 @@ jobs:
         run: |
           docker pull apache/gluten:vcpkg-centos-7
           docker run -v $GITHUB_WORKSPACE:/work -w /work apache/gluten:vcpkg-centos-7 bash -c "
+            set -e

Review Comment:
   @PHILO-HE Thanks for your tip, it seems that adding `set -e` here can pass the error. https://github.com/apache/incubator-gluten/actions/runs/13919427805/job/38949010930?pr=9028



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9027][VL] Check artifact files found for build native lib job [incubator-gluten]

Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #9028:
URL: https://github.com/apache/incubator-gluten/pull/9028#discussion_r2000572902


##########
.github/workflows/velox_backend.yml:
##########
@@ -85,6 +85,7 @@ jobs:
         run: |
           docker pull apache/gluten:vcpkg-centos-7
           docker run -v $GITHUB_WORKSPACE:/work -w /work apache/gluten:vcpkg-centos-7 bash -c "
+            set -e

Review Comment:
   @wForget, great! Please remove useless changes. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org

Re: [PR] [GLUTEN-9027][VL] Make CI fail fast if native build job fails [incubator-gluten]

Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE merged PR #9028:
URL: https://github.com/apache/incubator-gluten/pull/9028


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org