You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by richard zhou <ri...@intel.com> on 2015/05/28 09:25:42 UTC
Review Request 34759: SQOOP-2375: Add authorization component in
SecurityGuide
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34759/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
Add authorization component in SecurityGuide
Diffs
-----
docs/src/site/sphinx/SecurityGuideOnSqoop2.rst 0a6d19213a6ee950ffa1796f899d3b58c2706870
Diff: https://reviews.apache.org/r/34759/diff/
Testing
-------
N/A
Thanks,
richard zhou
Re: Review Request 34759: SQOOP-2375: Add authorization component in
SecurityGuide
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34759/#review85582
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On May 28, 2015, 8:44 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34759/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 8:44 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Add authorization component in SecurityGuide
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/SecurityGuideOnSqoop2.rst 0a6d19213a6ee950ffa1796f899d3b58c2706870
>
> Diff: https://reviews.apache.org/r/34759/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 34759: SQOOP-2375: Add authorization component in
SecurityGuide
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34759/
-----------------------------------------------------------
(Updated May 28, 2015, 8:44 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
Add authorization component in SecurityGuide
Diffs (updated)
-----
docs/src/site/sphinx/SecurityGuideOnSqoop2.rst 0a6d19213a6ee950ffa1796f899d3b58c2706870
Diff: https://reviews.apache.org/r/34759/diff/
Testing
-------
N/A
Thanks,
richard zhou
Re: Review Request 34759: SQOOP-2375: Add authorization component in
SecurityGuide
Posted by richard zhou <ri...@intel.com>.
> On May 28, 2015, 7:37 a.m., Abraham Elmahrek wrote:
> > docs/src/site/sphinx/SecurityGuideOnSqoop2.rst, line 22
> > <https://reviews.apache.org/r/34759/diff/1/?file=973411#file973411line22>
> >
> > Insert space above
Move this sentense to the first paragraph.
If spaces is added, the generated format seems not align with the first paragraph. Correct me if I am wrong.
- richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34759/#review85527
-----------------------------------------------------------
On May 28, 2015, 8:44 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34759/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 8:44 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Add authorization component in SecurityGuide
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/SecurityGuideOnSqoop2.rst 0a6d19213a6ee950ffa1796f899d3b58c2706870
>
> Diff: https://reviews.apache.org/r/34759/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 34759: SQOOP-2375: Add authorization component in
SecurityGuide
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34759/#review85527
-----------------------------------------------------------
Ship it!
LGTM!
docs/src/site/sphinx/SecurityGuideOnSqoop2.rst
<https://reviews.apache.org/r/34759/#comment137101>
Insert space above
- Abraham Elmahrek
On May 28, 2015, 7:25 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34759/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 7:25 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Add authorization component in SecurityGuide
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/SecurityGuideOnSqoop2.rst 0a6d19213a6ee950ffa1796f899d3b58c2706870
>
> Diff: https://reviews.apache.org/r/34759/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> richard zhou
>
>