You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/01/22 22:29:34 UTC

[I] Remove dependency on physical-optimizer on functions-aggregates [datafusion]

alamb opened a new issue, #14243:
URL: https://github.com/apache/datafusion/issues/14243

                 I would like to avoid this dependency if possible -- I will like to make a follow on PR to remove it -- similar to how I did in https://github.com/apache/datafusion/pull/14134
   
   However when I just used the stub a few tests started failing on me
   
   _Originally posted by @alamb in https://github.com/apache/datafusion/pull/14190#discussion_r1926059317_
               


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Remove dependency on physical-optimizer on functions-aggregates [datafusion]

Posted by "berkaysynnada (via GitHub)" <gi...@apache.org>.
berkaysynnada commented on issue #14243:
URL: https://github.com/apache/datafusion/issues/14243#issuecomment-2609476826

   I've an idea. You're moving all tests to core/physical_optimizer with https://github.com/apache/datafusion/pull/14244. So, as of now, if we are writing tests core/physical_optimizer for physical optimizers, then datafusion/physical_optimizer/test_utils.rs can also be moved to core/physical_optimizer, and that will remove this dep. WDYT? If it sounds good, let's put all others (join_selection, limit-pushdown and more if there are) and test_utils into that PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Remove dependency on physical-optimizer on functions-aggregates [datafusion]

Posted by "berkaysynnada (via GitHub)" <gi...@apache.org>.
berkaysynnada commented on issue #14243:
URL: https://github.com/apache/datafusion/issues/14243#issuecomment-2609479704

   > I've an idea. You're moving all tests to core/physical_optimizer with [#14244](https://github.com/apache/datafusion/pull/14244). So, as of now, if we are writing tests core/physical_optimizer for physical optimizers, then datafusion/physical_optimizer/test_utils.rs can also be moved to core/physical_optimizer, and that will remove this dep. WDYT? If it sounds good, let's put all others (join_selection, limit-pushdown and more if there are) and test_utils into that PR.
   
   I can do that BTW if you are okay, and then work on https://github.com/apache/datafusion/pull/14235/files, and finally delete the core/physical_optimizer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Remove dependency on physical-optimizer on functions-aggregates [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #14243: Remove dependency on physical-optimizer on functions-aggregates
URL: https://github.com/apache/datafusion/issues/14243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Remove dependency on physical-optimizer on functions-aggregates [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #14243:
URL: https://github.com/apache/datafusion/issues/14243#issuecomment-2608401191

   We are trying to make sure `datafusion-physical-optimizers` are not dependent on the actual function implementations so ensuring the crate doesn't have dependency will let the compiler ensure this
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Remove dependency on physical-optimizer on functions-aggregates [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #14243:
URL: https://github.com/apache/datafusion/issues/14243#issuecomment-2611148405

   > I've an idea. You're moving all tests to core/physical_optimizer with [#14244](https://github.com/apache/datafusion/pull/14244). So, as of now, if we are writing tests core/physical_optimizer for physical optimizers, then datafusion/physical_optimizer/test_utils.rs can also be moved to core/physical_optimizer, and that will remove this dep. WDYT? If it sounds good, let's put all others (join_selection, limit-pushdown and more if there are) and test_utils into that PR.
   
   Yes I think that sounds like a great idea. It would solve this issue too ❤ 
   
   THANK YOU
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org