[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm

[GitBox <gi...@apache.org>]

i3wangyi commented on a change in pull request #381: Implement the basic constraint based algorithm
URL: https://github.com/apache/helix/pull/381#discussion_r320930793
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/SoftConstraint.java
 ##########
 @@ -27,7 +27,7 @@
  * Evaluate a partition allocation proposal and return a score within the normalized range.
  * A higher score means the proposal is more preferred.
  */
-abstract class SoftConstraint {
+public abstract class SoftConstraint {
 
 Review comment:
   If you'd like to use a rebalance algorithm factory, at least this factory needs to know about interfaces.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org