[GitHub] [hudi] nsivabalan commented on a diff in pull request #5269: [HUDI-3636] Create new write clients for async table services in DeltaStreamer and Spark streaking sink

[GitBox <gi...@apache.org>]

nsivabalan commented on code in PR #5269:
URL: https://github.com/apache/hudi/pull/5269#discussion_r1000006472


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java:
##########
@@ -47,4 +60,11 @@ public void start(Function<Boolean, Boolean> onShutdownCallback) {
     }
     super.start(onShutdownCallback);
   }
+
+  public void updateWriteConfig(HoodieWriteConfig writeConfig) {
+    synchronized (writeConfigUpdateLock) {
+      this.writeConfig = EmbeddedTimelineServerHelper.updateWriteConfigWithTimelineServer(embeddedTimelineService.get(), writeConfig);
+      isWriteConfigUpdated.set(true);

Review Comment:
   let's sync up. I am not sure if I understood your comment fully.
   we can't update the writeConfig synchronously. The crux here is that, we need to re-instantiate a new writeClient if writeconfig is updated. but, we can give up on entire locking since all we care is, next time when compaction runs it should re-instate itself w/ updated write config. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org