You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2015/12/17 00:39:21 UTC
Review Request 41475: Updated docker build script for centos 7.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41475/
-----------------------------------------------------------
Review request for mesos, Greg Mann, Joris Van Remoortere, and Michael Park.
Bugs: MESOS-4184
https://issues.apache.org/jira/browse/MESOS-4184
Repository: mesos
Description
-------
Jenkins builds are consistently failing for centos 7, with the
failure:
checking value of Java system property 'java.home'...
/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.65-3.b17.el7.x86_64/jre
configure: error: could not guess JAVA_HOME
They also fail early on during 'bootstrap' with a missing 'which'
command.
The solution is to update support/docker_build.sh to install 'which' as
well as make sure the proper versions of java are installed during the
installation process.
The problem with java is that we install maven BEFORE installing
java-1.7.0-openjdk-devel, causing maven to pull in a dependency on
java-1.8.0-openjdk. This causes problems with finding the proper
java.home in our mesos/configure script because of the mismatch between
the most up to date jre (1.8.0) and the most up to date development
tools (1.7.0). We can either update the script to pull in the 1.8 devel
tools or move our dependence on maven until AFTER our installation of
java-1.7.0-openjdk-devel.
This commit takes the approach of updating to explicitly install the
java-1.8.0 tools.
Diffs
-----
support/docker_build.sh c14370dcf5c0ccb883d798d9771b5503fa81c9a5
Diff: https://reviews.apache.org/r/41475/diff/
Testing
-------
Thanks,
Kevin Klues
Re: Review Request 41475: Updated docker build script for centos 7.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41475/#review111050
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41475]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 16, 2015, 11:39 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41475/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 11:39 p.m.)
>
>
> Review request for mesos, Greg Mann, Joris Van Remoortere, and Michael Park.
>
>
> Bugs: MESOS-4184
> https://issues.apache.org/jira/browse/MESOS-4184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Jenkins builds are consistently failing for centos 7, with the
> failure:
>
> checking value of Java system property 'java.home'...
> /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.65-3.b17.el7.x86_64/jre
> configure: error: could not guess JAVA_HOME
>
> They also fail early on during 'bootstrap' with a missing 'which'
> command.
>
> The solution is to update support/docker_build.sh to install 'which' as
> well as make sure the proper versions of java are installed during the
> installation process.
>
> The problem with java is that we install maven BEFORE installing
> java-1.7.0-openjdk-devel, causing maven to pull in a dependency on
> java-1.8.0-openjdk. This causes problems with finding the proper
> java.home in our mesos/configure script because of the mismatch between
> the most up to date jre (1.8.0) and the most up to date development
> tools (1.7.0). We can either update the script to pull in the 1.8 devel
> tools or move our dependence on maven until AFTER our installation of
> java-1.7.0-openjdk-devel.
>
> This commit takes the approach of updating to explicitly install the
> java-1.8.0 tools.
>
>
> Diffs
> -----
>
> support/docker_build.sh c14370dcf5c0ccb883d798d9771b5503fa81c9a5
>
> Diff: https://reviews.apache.org/r/41475/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 41475: Updated docker build script for centos 7.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41475/#review111084
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Dec. 16, 2015, 11:39 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41475/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 11:39 p.m.)
>
>
> Review request for mesos, Greg Mann, Joris Van Remoortere, and Michael Park.
>
>
> Bugs: MESOS-4184
> https://issues.apache.org/jira/browse/MESOS-4184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Jenkins builds are consistently failing for centos 7, with the
> failure:
>
> checking value of Java system property 'java.home'...
> /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.65-3.b17.el7.x86_64/jre
> configure: error: could not guess JAVA_HOME
>
> They also fail early on during 'bootstrap' with a missing 'which'
> command.
>
> The solution is to update support/docker_build.sh to install 'which' as
> well as make sure the proper versions of java are installed during the
> installation process.
>
> The problem with java is that we install maven BEFORE installing
> java-1.7.0-openjdk-devel, causing maven to pull in a dependency on
> java-1.8.0-openjdk. This causes problems with finding the proper
> java.home in our mesos/configure script because of the mismatch between
> the most up to date jre (1.8.0) and the most up to date development
> tools (1.7.0). We can either update the script to pull in the 1.8 devel
> tools or move our dependence on maven until AFTER our installation of
> java-1.7.0-openjdk-devel.
>
> This commit takes the approach of updating to explicitly install the
> java-1.8.0 tools.
>
>
> Diffs
> -----
>
> support/docker_build.sh c14370dcf5c0ccb883d798d9771b5503fa81c9a5
>
> Diff: https://reviews.apache.org/r/41475/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 41475: Updated docker build script for centos 7.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41475/#review110952
-----------------------------------------------------------
Ship it!
I confirmed that the original script failed as described with `OS=centos:7`, then tested the updated script with `OS=centos:7` and `OS=ubuntu:14.04`, and it looks good!
- Greg Mann
On Dec. 16, 2015, 11:39 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41475/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 11:39 p.m.)
>
>
> Review request for mesos, Greg Mann, Joris Van Remoortere, and Michael Park.
>
>
> Bugs: MESOS-4184
> https://issues.apache.org/jira/browse/MESOS-4184
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Jenkins builds are consistently failing for centos 7, with the
> failure:
>
> checking value of Java system property 'java.home'...
> /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.65-3.b17.el7.x86_64/jre
> configure: error: could not guess JAVA_HOME
>
> They also fail early on during 'bootstrap' with a missing 'which'
> command.
>
> The solution is to update support/docker_build.sh to install 'which' as
> well as make sure the proper versions of java are installed during the
> installation process.
>
> The problem with java is that we install maven BEFORE installing
> java-1.7.0-openjdk-devel, causing maven to pull in a dependency on
> java-1.8.0-openjdk. This causes problems with finding the proper
> java.home in our mesos/configure script because of the mismatch between
> the most up to date jre (1.8.0) and the most up to date development
> tools (1.7.0). We can either update the script to pull in the 1.8 devel
> tools or move our dependence on maven until AFTER our installation of
> java-1.7.0-openjdk-devel.
>
> This commit takes the approach of updating to explicitly install the
> java-1.8.0 tools.
>
>
> Diffs
> -----
>
> support/docker_build.sh c14370dcf5c0ccb883d798d9771b5503fa81c9a5
>
> Diff: https://reviews.apache.org/r/41475/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Klues
>
>