You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2019/01/04 09:08:57 UTC

[GitHub] carbondata pull request #3051: [CARBONDATA-3221] Fix the error of SDK don't ...

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/3051

    [CARBONDATA-3221] Fix the error of SDK don't support read multiple file from S3     

    
        SDK reader is ok with filter, but when we read data without filter, the ((CarbonInputSplit) inputSplit).getDetailInfo().getBlockFooterOffset() will be 0 and
        FileReader reader don't closed after readByteBuffer in org.apache.carbondata.hadoop.util.CarbonVectorizedRecordReader#initialize, so we should invoke finish after readByteBuffer
    
    
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           change test case in example
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata CARBONDATA-3221_SDKSupportMultipleFiles

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3051.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3051
    
----
commit fd2858083f8a9041c67f4f8192096b52ed0cf0e1
Author: xubo245 <xu...@...>
Date:   2019-01-04T08:53:48Z

    [CARBONDATA-3221] Fix the error of SDK don't support read multiple file from S3
    
    SDK reader is ok with filter, but when we read data without filter, the ((CarbonInputSplit) inputSplit).getDetailInfo().getBlockFooterOffset() will be 0 and
    FileReader reader don't closed after readByteBuffer in org.apache.carbondata.hadoop.util.CarbonVectorizedRecordReader#initialize, so we should invoke finish after readByteBuffer

commit f47fc32de498b99342593518be5ffe0f08d41ead
Author: xubo245 <xu...@...>
Date:   2019-01-04T09:06:06Z

    add config

----


---

[GitHub] carbondata issue #3051: [CARBONDATA-3221] Fix the error of SDK don't support...

Posted by xubo245 <gi...@git.apache.org>.

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/3051
  
    @KanakaKumar @kunal642 @jackylk @QiangCai @zzcclp @ravikiran23 Please review it.


---