You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Felix Schumacher <fe...@internetallee.de> on 2017/02/11 16:49:06 UTC
Re: svn commit: r1782611 - /jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/HtmlTemplateExporter.java
Am 11. Februar 2017 16:20:41 MEZ schrieb pmouawad@apache.org:
>Author: pmouawad
>Date: Sat Feb 11 15:20:41 2017
>New Revision: 1782611
>
>URL: http://svn.apache.org/viewvc?rev=1782611&view=rev
>Log:
>Add debug logs
>
>Modified:
>jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/HtmlTemplateExporter.java
>
>Modified:
>jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/HtmlTemplateExporter.java
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/HtmlTemplateExporter.java?rev=1782611&r1=1782610&r2=1782611&view=diff
>==============================================================================
>---
>jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/HtmlTemplateExporter.java
>(original)
>+++
>jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/HtmlTemplateExporter.java
>Sat Feb 11 15:20:41 2017
>@@ -253,11 +253,23 @@ public class HtmlTemplateExporter extend
> || !supportsControllerDiscrimination.booleanValue()
> || isController
> || !showControllerSeriesOnly;
>+ if(log.isDebugEnabled()) {
>+ log.debug("name:{} matches
>pattern:{}, supportsControllerDiscrimination:{}, isController:{},
>showControllerSeriesOnly:{}",
>+ name,
>filterPattern.pattern(),
>+
>supportsControllerDiscrimination, isController,
>showControllerSeriesOnly);
>+ }
> } else {
> // If the name does not match the pattern,
> // other properties can hold the series
> matches = filtersOnlySampleSeries
> && !supportsControllerDiscrimination.booleanValue();
>+ if(log.isDebugEnabled()) {
>+ log.debug("name:{} does not
>match pattern:{}, filtersOnlySampleSeries:{},"
>+ + "
>supportsControllerDiscrimination:{}",
>+ name,
>filterPattern.pattern(),
>+ filtersOnlySampleSeries,
>+
>supportsControllerDiscrimination);
>+ }
> }
> }
> index++;
>@@ -495,4 +507,8 @@ public class HtmlTemplateExporter extend
>
> }
>
>+ public static void main(String[] args) {
>+ Pattern filterPattern =
>Pattern.compile("((^EnleverArticle)|(^ModifierQuantite)|(^VoirPanier)|(^AjoutPanier)|(^ChoixMagasin)|(^ChangerMagasin)|(^VoirPanier)|(^ClickProduit)|(^ClicTriPrix)|(^ClickPagination)|(^AjoutProduitPourComparison)|(^ClickComparer)|(^ChoixCategorie)|(^ChoixSousCategorie)|(^ClickFiltrer)|(^RechercheFullText)|(^Autocomplete)|(^Rechercher)|(^HP_Mag)|(^ChoixMag)|(^HP))(-success|-failure)?");
>+
>System.out.println(filterPattern.matcher("ChoixSousCategorie").matches());
>+ }
A main method to test something? Why not use a test.
When I use such a complex regex, I usually try to generate it with some sort of join.
Regards,
Felix
> }
Re: svn commit: r1782611 - /jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/HtmlTemplateExporter.java
Posted by Philippe Mouawad <ph...@gmail.com>.
wrong commit.
I just wanted to. commit the logs.
Thanks
I agree with you Felix.
On Saturday, February 11, 2017, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:
>
>
> Am 11. Februar 2017 16:20:41 MEZ schrieb pmouawad@apache.org
> <javascript:;>:
> >Author: pmouawad
> >Date: Sat Feb 11 15:20:41 2017
> >New Revision: 1782611
> >
> >URL: http://svn.apache.org/viewvc?rev=1782611&view=rev
> >Log:
> >Add debug logs
> >
> >Modified:
> >jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/
> HtmlTemplateExporter.java
> >
> >Modified:
> >jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/
> HtmlTemplateExporter.java
> >URL:
> >http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/
> apache/jmeter/report/dashboard/HtmlTemplateExporter.java?rev=
> 1782611&r1=1782610&r2=1782611&view=diff
> >===========================================================
> ===================
> >---
> >jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/
> HtmlTemplateExporter.java
> >(original)
> >+++
> >jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/
> HtmlTemplateExporter.java
> >Sat Feb 11 15:20:41 2017
> >@@ -253,11 +253,23 @@ public class HtmlTemplateExporter extend
> > || !supportsControllerDiscrimination.booleanValue()
> > || isController
> > || !showControllerSeriesOnly;
> >+ if(log.isDebugEnabled()) {
> >+ log.debug("name:{} matches
> >pattern:{}, supportsControllerDiscrimination:{}, isController:{},
> >showControllerSeriesOnly:{}",
> >+ name,
> >filterPattern.pattern(),
> >+
> >supportsControllerDiscrimination, isController,
> >showControllerSeriesOnly);
> >+ }
> > } else {
> > // If the name does not match the pattern,
> > // other properties can hold the series
> > matches = filtersOnlySampleSeries
> > && !supportsControllerDiscrimination.booleanValue();
> >+ if(log.isDebugEnabled()) {
> >+ log.debug("name:{} does not
> >match pattern:{}, filtersOnlySampleSeries:{},"
> >+ + "
> >supportsControllerDiscrimination:{}",
> >+ name,
> >filterPattern.pattern(),
> >+ filtersOnlySampleSeries,
> >+
> >supportsControllerDiscrimination);
> >+ }
> > }
> > }
> > index++;
> >@@ -495,4 +507,8 @@ public class HtmlTemplateExporter extend
> >
> > }
> >
> >+ public static void main(String[] args) {
> >+ Pattern filterPattern =
> >Pattern.compile("((^EnleverArticle)|(^ModifierQuantite)|(^
> VoirPanier)|(^AjoutPanier)|(^ChoixMagasin)|(^
> ChangerMagasin)|(^VoirPanier)|(^ClickProduit)|(^ClicTriPrix)
> |(^ClickPagination)|(^AjoutProduitPourComparison)|(^ClickComparer)|(^
> ChoixCategorie)|(^ChoixSousCategorie)|(^ClickFiltrer)|(^
> RechercheFullText)|(^Autocomplete)|(^Rechercher)|(^
> HP_Mag)|(^ChoixMag)|(^HP))(-success|-failure)?");
> >+
> >System.out.println(filterPattern.matcher("ChoixSousCategorie").matches()
> );
> >+ }
>
> A main method to test something? Why not use a test.
>
> When I use such a complex regex, I usually try to generate it with some
> sort of join.
>
> Regards,
> Felix
>
> > }
>
--
Cordialement.
Philippe Mouawad.