You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/03/01 15:45:23 UTC
[GitHub] couchdb pull request: add test for _changes?feed=stream
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb/pull/307
add test for _changes?feed=stream
COUCHDB-2237
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb 2237-stream
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/307.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #307
----
commit b63900e7942e7f8f67a69ce5e4c99cea2f2191ac
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2015-03-01T14:40:51Z
add test for _changes?feed=stream
COUCHDB-2237
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: add test for _changes?feed=stream
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/307#discussion_r25568562
--- Diff: test/javascript/tests/changes.js ---
@@ -17,131 +17,140 @@ function jsonp(obj) {
}
couchTests.changes = function(debug) {
- var db = new CouchDB("test_suite_db", {"X-Couch-Full-Commit":"true"});
- db.deleteDb();
- db.createDb();
+ var db;
if (debug) debugger;
- var req = CouchDB.request("GET", "/test_suite_db/_changes");
- var resp = JSON.parse(req.responseText);
+ // poor man's browser detection
--- End diff --
good to know, i can remove it, it is part of the older code that i moved into a function to make it reusable
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: add test for _changes?feed=stream
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb/pull/307
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: add test for _changes?feed=stream
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/307#discussion_r25567954
--- Diff: test/javascript/tests/changes.js ---
@@ -17,131 +17,140 @@ function jsonp(obj) {
}
couchTests.changes = function(debug) {
- var db = new CouchDB("test_suite_db", {"X-Couch-Full-Commit":"true"});
- db.deleteDb();
- db.createDb();
+ var db;
if (debug) debugger;
- var req = CouchDB.request("GET", "/test_suite_db/_changes");
- var resp = JSON.parse(req.responseText);
+ // poor man's browser detection
--- End diff --
Not sure if this is ever need since we drop feature to run the test suite from browser.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---