You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/18 11:44:31 UTC
[GitHub] [incubator-inlong] healchow opened a new pull request #3229: [INLONG-3228][Manager] Deadlock found when trying to get lock
healchow opened a new pull request #3229:
URL: https://github.com/apache/incubator-inlong/pull/3229
### Title Name: [INLONG-3228][Manager] Deadlock found when trying to get lock
Fixes #3228
### Motivation
Deadlock found when trying to get lock.
### Modifications
1. Not use `select for update` when querying sources by related id.
2. Add some logs.
### Verifying this change
- [X] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gong commented on a change in pull request #3229: [INLONG-3228][Manager] Deadlock found when trying to get lock
Posted by GitBox <gi...@apache.org>.
gong commented on a change in pull request #3229:
URL: https://github.com/apache/incubator-inlong/pull/3229#discussion_r829953372
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java
##########
@@ -112,7 +112,7 @@ public Boolean reportSnapshot(TaskSnapshotRequest request) {
@Override
@Transactional(rollbackFor = Throwable.class, isolation = Isolation.REPEATABLE_READ)
Review comment:
why not to modify `Isolation.REPEATABLE_READ` to `Isolation.READ_COMMITTED`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #3229: [INLONG-3228][Manager] Deadlock found when trying to get lock
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #3229:
URL: https://github.com/apache/incubator-inlong/pull/3229#discussion_r829955306
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java
##########
@@ -112,7 +112,7 @@ public Boolean reportSnapshot(TaskSnapshotRequest request) {
@Override
@Transactional(rollbackFor = Throwable.class, isolation = Isolation.REPEATABLE_READ)
Review comment:
Because the inner method `getTaskResult` needs `Isolation.READ_COMMITTED`.
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java
##########
@@ -112,7 +112,7 @@ public Boolean reportSnapshot(TaskSnapshotRequest request) {
@Override
@Transactional(rollbackFor = Throwable.class, isolation = Isolation.REPEATABLE_READ)
Review comment:
Because the inner method `getTaskResult` needs `Isolation.REPEATABLE_READ `.
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java
##########
@@ -112,7 +112,7 @@ public Boolean reportSnapshot(TaskSnapshotRequest request) {
@Override
@Transactional(rollbackFor = Throwable.class, isolation = Isolation.REPEATABLE_READ)
Review comment:
Because the inner method `getTaskResult` needs `Isolation.REPEATABLE_READ`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #3229: [INLONG-3228][Manager] Deadlock found when trying to get lock
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #3229:
URL: https://github.com/apache/incubator-inlong/pull/3229#discussion_r829955306
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java
##########
@@ -112,7 +112,7 @@ public Boolean reportSnapshot(TaskSnapshotRequest request) {
@Override
@Transactional(rollbackFor = Throwable.class, isolation = Isolation.REPEATABLE_READ)
Review comment:
Because the inner method `getTaskResult` needs `Isolation.READ_COMMITTED`.
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java
##########
@@ -112,7 +112,7 @@ public Boolean reportSnapshot(TaskSnapshotRequest request) {
@Override
@Transactional(rollbackFor = Throwable.class, isolation = Isolation.REPEATABLE_READ)
Review comment:
Because the inner method `getTaskResult` needs `Isolation.REPEATABLE_READ `.
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java
##########
@@ -112,7 +112,7 @@ public Boolean reportSnapshot(TaskSnapshotRequest request) {
@Override
@Transactional(rollbackFor = Throwable.class, isolation = Isolation.REPEATABLE_READ)
Review comment:
Because the inner method `getTaskResult` needs `Isolation.REPEATABLE_READ`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #3229: [INLONG-3228][Manager] Deadlock found when trying to get lock
Posted by GitBox <gi...@apache.org>.
healchow merged pull request #3229:
URL: https://github.com/apache/incubator-inlong/pull/3229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #3229: [INLONG-3228][Manager] Deadlock found when trying to get lock
Posted by GitBox <gi...@apache.org>.
healchow merged pull request #3229:
URL: https://github.com/apache/incubator-inlong/pull/3229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gong commented on a change in pull request #3229: [INLONG-3228][Manager] Deadlock found when trying to get lock
Posted by GitBox <gi...@apache.org>.
gong commented on a change in pull request #3229:
URL: https://github.com/apache/incubator-inlong/pull/3229#discussion_r829953372
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java
##########
@@ -112,7 +112,7 @@ public Boolean reportSnapshot(TaskSnapshotRequest request) {
@Override
@Transactional(rollbackFor = Throwable.class, isolation = Isolation.REPEATABLE_READ)
Review comment:
why not to modify `Isolation.REPEATABLE_READ` to `Isolation.READ_COMMITTED`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org