[GitHub] [lucene] zhaih commented on a diff in pull request #12034: Remove null check in IndexReaderContext#leaves() usages

[GitBox <gi...@apache.org>]

zhaih commented on code in PR #12034:
URL: https://github.com/apache/lucene/pull/12034#discussion_r1063684215


##########
lucene/core/src/java/org/apache/lucene/search/BlendedTermQuery.java:
##########
@@ -314,19 +314,15 @@ private static TermStates adjustFrequencies(
       IndexReaderContext readerContext, TermStates ctx, int artificialDf, long artificialTtf)
       throws IOException {
     List<LeafReaderContext> leaves = readerContext.leaves();
-    final int len;
-    if (leaves == null) {
-      len = 1;
-    } else {
-      len = leaves.size();
-    }
     TermStates newCtx = new TermStates(readerContext);
-    for (int i = 0; i < len; ++i) {
-      TermState termState = ctx.get(leaves.get(i));
-      if (termState == null) {
-        continue;
+    if (leaves != null) {

Review Comment:
   Thanks for changing it, I think it is better to leave a CHNAGES.txt entry anyway!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org