You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2023/01/28 08:01:19 UTC

[GitHub] [hudi] yihua opened a new pull request, #7775: [HUDI-5635] Fix release scripts

yihua opened a new pull request, #7775:
URL: https://github.com/apache/hudi/pull/7775

   ### Change Logs
   
   This PR fix the release scripts:
   - `cut_release_branch.sh`: `git push` to master is no longer allowed.  Any commit to merge to master needs approval from a committer.  So `git push origin ${MASTER_BRANCH}` is removed from the script.  A new branch is created for the version upgrade on the master, and the script prompts the release manager to manually open a PR for this.
   - `deploy_staging_jars.sh`: Previously, both mvn commands for each profile run tests and upload the jars to the staging area, which is a waste of time.  This issue is fixed in this PR.  Also, adjusts the profiles to be comprehensive and efficient.
   - `validate_staged_bundles.sh`: Adds new bundles generated.
   
   ### Impact
   
   Makes sure the scripts run smoothly, efficiently, up to date based on the new bundles.
   
   ### Risk level
   
   none
   
   ### Documentation Update
   
   N/A
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on a diff in pull request #7775: [HUDI-5635] Fix release scripts

Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #7775:
URL: https://github.com/apache/hudi/pull/7775#discussion_r1089678703


##########
scripts/release/deploy_staging_jars.sh:
##########
@@ -97,14 +97,13 @@ elif [ "$#" == "1" ]; then
   exit 1
 fi
 
-COMMON_OPTIONS="-DdeployArtifacts=true -DskipTests -DretryFailedDeploymentCount=10"
 for v in "${ALL_VERSION_OPTS[@]}"
 do
   # clean everything before any round of depoyment
   $MVN clean
   echo "Building with options ${v}"
-  $MVN install "$COMMON_OPTIONS" "${v}"
+  $MVN install -DskipTests ${v}

Review Comment:
   double check if integ test module will be skipped or not



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7775: [HUDI-5635] Fix release scripts

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7775:
URL: https://github.com/apache/hudi/pull/7775#issuecomment-1407331038

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "64a2c1d5b53e5d9083c7c46d54eb7ab6fa6f1057",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "64a2c1d5b53e5d9083c7c46d54eb7ab6fa6f1057",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 64a2c1d5b53e5d9083c7c46d54eb7ab6fa6f1057 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7775: [HUDI-5635] Fix release scripts

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7775:
URL: https://github.com/apache/hudi/pull/7775#issuecomment-1407336066

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "64a2c1d5b53e5d9083c7c46d54eb7ab6fa6f1057",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "64a2c1d5b53e5d9083c7c46d54eb7ab6fa6f1057",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7db6c47cbdf8159ee4f97f03eda2fdb395e5d56c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7db6c47cbdf8159ee4f97f03eda2fdb395e5d56c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 64a2c1d5b53e5d9083c7c46d54eb7ab6fa6f1057 UNKNOWN
   * 7db6c47cbdf8159ee4f97f03eda2fdb395e5d56c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #7775: [HUDI-5635] Fix release scripts

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #7775:
URL: https://github.com/apache/hudi/pull/7775


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org