You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by fe...@apache.org on 2007/11/13 14:06:33 UTC

svn commit: r594521 - in /cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms: binding/library/LibraryManagerImpl.java formmodel/library/LibraryManagerImpl.java

Author: felixk
Date: Tue Nov 13 05:06:32 2007
New Revision: 594521

URL: http://svn.apache.org/viewvc?rev=594521&view=rev
Log:
Don't catch RuntimeException, otherwise hardcoded deprecation of org/apache/cocoon/forms/binding/CustomJXPathBindingBuilder.java isn't shown anywhere.

Modified:
    cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/binding/library/LibraryManagerImpl.java
    cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/formmodel/library/LibraryManagerImpl.java

Modified: cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/binding/library/LibraryManagerImpl.java
URL: http://svn.apache.org/viewvc/cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/binding/library/LibraryManagerImpl.java?rev=594521&r1=594520&r2=594521&view=diff
==============================================================================
--- cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/binding/library/LibraryManagerImpl.java (original)
+++ cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/binding/library/LibraryManagerImpl.java Tue Nov 13 05:06:32 2007
@@ -131,6 +131,8 @@
                     lib.buildLibrary(doc.getDocumentElement());
 
                     this.cacheManager.set(lib,source,PREFIX);
+                } catch (RuntimeException re) {
+                    throw new RuntimeException(re);
                 } catch (Exception e) {
                     throw new LibraryException("Unable to load library.",
                                                e, new LocationImpl("[LibraryManager]", source.getURI()));

Modified: cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/formmodel/library/LibraryManagerImpl.java
URL: http://svn.apache.org/viewvc/cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/formmodel/library/LibraryManagerImpl.java?rev=594521&r1=594520&r2=594521&view=diff
==============================================================================
--- cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/formmodel/library/LibraryManagerImpl.java (original)
+++ cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/formmodel/library/LibraryManagerImpl.java Tue Nov 13 05:06:32 2007
@@ -125,6 +125,8 @@
                     lib.buildLibrary(doc.getDocumentElement());
 
                     this.cacheManager.set(lib, source, PREFIX);
+                } catch (RuntimeException re) {
+                    throw new RuntimeException(re);
                 } catch (Exception e) {
                     throw new LibraryException("Unable to load library.",
                                                e, new LocationImpl("[LibraryManager]", source.getURI()));

Re: svn commit: r594521 - in /cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms: binding/library/LibraryManagerImpl.java formmodel/library/LibraryManagerImpl.java

Posted by Felix Knecht <fe...@apache.org>.
Joerg Heinicke schrieb:
> On 13.11.2007 8:06 Uhr, felixk@apache.org wrote:
>> Author: felixk
>> Date: Tue Nov 13 05:06:32 2007
>> New Revision: 594521
>>
>> URL: http://svn.apache.org/viewvc?rev=594521&view=rev
>> Log:
>> Don't catch RuntimeException, otherwise hardcoded deprecation of
>> org/apache/cocoon/forms/binding/CustomJXPathBindingBuilder.java isn't
>> shown anywhere.
>
> You neither need to wrap it, just do "throw re;"
Thanks for spotting.

Felix
>
> Joerg
>

Re: svn commit: r594521 - in /cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms: binding/library/LibraryManagerImpl.java formmodel/library/LibraryManagerImpl.java

Posted by Joerg Heinicke <jo...@gmx.de>.
On 13.11.2007 8:06 Uhr, felixk@apache.org wrote:
> Author: felixk
> Date: Tue Nov 13 05:06:32 2007
> New Revision: 594521
> 
> URL: http://svn.apache.org/viewvc?rev=594521&view=rev
> Log:
> Don't catch RuntimeException, otherwise hardcoded deprecation of org/apache/cocoon/forms/binding/CustomJXPathBindingBuilder.java isn't shown anywhere.

You neither need to wrap it, just do "throw re;"

Joerg