[jira] [Commented] (HDFS-6030) Remove an unused constructor in INode.java

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-6030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13916181#comment-13916181 ] 

Hudson commented on HDFS-6030:
------------------------------

SUCCESS: Integrated in Hadoop-trunk-Commit #5245 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5245/])
HDFS-6030.  Remove an unused constructor in INode.java (yzhang via cmccabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1573031)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java


> Remove an unused constructor in INode.java
> ------------------------------------------
>
>                 Key: HDFS-6030
>                 URL: https://issues.apache.org/jira/browse/HDFS-6030
>             Project: Hadoop HDFS
>          Issue Type: Task
>    Affects Versions: 2.3.0
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>            Priority: Trivial
>             Fix For: 2.4.0
>
>         Attachments: HDFS-6030.001.patch
>
>
> When I look at fix of HDFS-4879, I noticed that class BlocksMapUpdateInfo in INode.java,  has a constructor that still uses ArrayList<Block> (which HDFS-4879 tries to replace with ChunkedArrayList for better memory efficiency)
> {code}
>     public static class BlocksMapUpdateInfo { 
>     ...... 
>     public BlocksMapUpdateInfo(List<Block> toDeleteList) {
>       this.toDeleteList = toDeleteList == null ? new ArrayList<Block>()
>           : toDeleteList;
>     }
>     ......
>     }
> {code}
> It turns out that this constructor is not used anywhere (thanks [~cmccabe] for pointing this out). I'm filing this JIRA to remove it.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)