[GitHub] [incubator-superset] khtruong commented on a change in pull request #7436: feat: view presto row objects in data grid

[GitBox <gi...@apache.org>]

khtruong commented on a change in pull request #7436: feat: view presto row objects in data grid
URL: https://github.com/apache/incubator-superset/pull/7436#discussion_r280861796
 
 

 ##########
 File path: superset/db_engine_specs.py
 ##########
 @@ -1526,6 +1590,10 @@ def where_latest_partition(
                     return qry.where(Column(col_name) == value)
         return False
 
+    @classmethod
+    def _get_fields(cls, cols: List[dict]) -> List[ColumnClause]:
+        return BaseEngineSpec._get_fields(cols)
+
 
 Review comment:
   The class is derived from PrestoEngineSpec, which is then derived from BaseEngineSpec. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org