You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/25 01:37:21 UTC
[GitHub] [incubator-kyuubi] wForget opened a new issue, #2467: [Improvement] Remove close launchEngineOp in KyuubiSessionImpl#close
wForget opened a new issue, #2467:
URL: https://github.com/apache/incubator-kyuubi/issues/2467
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.
### What would you like to be improved?
As discussed in https://github.com/apache/incubator-kyuubi/pull/2452#issuecomment-1107749724, the `AbstractSession#close()` method will close all operations of session, so `closeOperation(launchEngineOp.getHandle)` in `KyuubiSessionImpl#close` seems redundant.
### How should we improve?
Remove `closeOperation(launchEngineOp.getHandle)` call in `KyuubiSessionImpl#close`
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed issue #2467: [Improvement] Remove close launchEngineOp in KyuubiSessionImpl#close
Posted by GitBox <gi...@apache.org>.
ulysses-you closed issue #2467: [Improvement] Remove close launchEngineOp in KyuubiSessionImpl#close
URL: https://github.com/apache/incubator-kyuubi/issues/2467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org