You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zhouxinyu (via GitHub)" <gi...@apache.org> on 2023/03/10 03:20:44 UTC

[GitHub] [rocketmq] zhouxinyu commented on a diff in pull request #6262: [ISSUE #6268] fix rocketmq-proxy does not work properly in k8s nodePort mode

zhouxinyu commented on code in PR #6262:
URL: https://github.com/apache/rocketmq/pull/6262#discussion_r1131908763


##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/route/RouteActivity.java:
##########
@@ -83,9 +83,9 @@ public CompletableFuture<QueryRouteResponse> queryRoute(ProxyContext ctx, QueryR
             }
 
             QueryRouteResponse response = QueryRouteResponse.newBuilder()
-                .setStatus(ResponseBuilder.getInstance().buildStatus(Code.OK, Code.OK.name()))
-                .addAllMessageQueues(messageQueueList)
-                .build();
+                    .setStatus(ResponseBuilder.getInstance().buildStatus(Code.OK, Code.OK.name()))
+                    .addAllMessageQueues(messageQueueList)
+                    .build();

Review Comment:
   It seems that there is a code style issue. Try importing the  [rmq_code_style](https://github.com/apache/rocketmq/blob/develop/style/rmq_codeStyle.xml) to avoid introduce unnecessary code changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org