You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by nazgul33 <gi...@git.apache.org> on 2016/08/17 05:07:24 UTC
[GitHub] zeppelin pull request #1336: [ZEPPELIN-1333] prevent calling runParagraph() ...
GitHub user nazgul33 opened a pull request:
https://github.com/apache/zeppelin/pull/1336
[ZEPPELIN-1333] prevent calling runParagraph() on shift-enter event
### What is this PR for?
when shift-enter is pressed in text box of dynamic form, the paragraph runs twice.
1) ng-enter event handler
2) global event handler
blocking shift-enter in ng-enter event handler, this issue could be resolved.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1333
### How should this be tested?
please see the attached screenshot attached in jira issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazgul33/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1336.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1336
----
commit 32e35759e30dd10b976f7ec0fe34f90bf19f786c
Author: DongHoon Han <na...@stevens-mbp.local>
Date: 2016-08-17T04:59:54Z
[ZEPPELIN-1333] prevent calling runParagraph() on shift-enter event
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1336: [ZEPPELIN-1333] prevent calling runParagraph() on shif...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1336
@corneadoug Can you review this PR first? @nazgul33 and you seem to resolve same issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1336: [ZEPPELIN-1333] prevent calling runParagraph() ...
Posted by nazgul33 <gi...@git.apache.org>.
Github user nazgul33 closed the pull request at:
https://github.com/apache/zeppelin/pull/1336
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1336: [ZEPPELIN-1333] prevent calling runParagraph() ...
Posted by nazgul33 <gi...@git.apache.org>.
GitHub user nazgul33 reopened a pull request:
https://github.com/apache/zeppelin/pull/1336
[ZEPPELIN-1333] prevent calling runParagraph() on shift-enter event
### What is this PR for?
when shift-enter is pressed in text box of dynamic form, the paragraph runs twice.
1) ng-enter event handler
2) global event handler
blocking shift-enter in ng-enter event handler, this issue could be resolved.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1333
### How should this be tested?
the test case above should return 1 with enter event and shift-enter event.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazgul33/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1336.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1336
----
commit 54c51425c31c757e0b6ee27a1b183f4e38448623
Author: Steven Han <na...@gmail.com>
Date: 2016-08-17T04:59:54Z
[ZEPPELIN-1333] prevent calling runParagraph() on shift-enter event
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1336: [ZEPPELIN-1333] prevent calling runParagraph() on shif...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1336
Looks great to me.
@corneadoug please, merge it to both _master_ and _branch-0.6_ as fix version is 0.6.2 for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1336: [ZEPPELIN-1333] prevent calling runParagraph() ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1336
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1336: [ZEPPELIN-1333] prevent calling runParagraph() on shif...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1336
@nazgul33 can you close/re-open this PR to re-trigger CI?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1336: [ZEPPELIN-1333] prevent calling runParagraph() on shif...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1336
Tested, I like this way better.
However, @nazgul33 next time it would be better to make a separate branch instead of making the PR from master.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1336: [ZEPPELIN-1333] prevent calling runParagraph() on shif...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1336
Yes, agreed, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1336: [ZEPPELIN-1333] prevent calling runParagraph() on shif...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1336
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1336: [ZEPPELIN-1333] prevent calling runParagraph() on shif...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1336
@jongyoul Yes, and Front-end tests are green too.
So let's merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1336: [ZEPPELIN-1333] prevent calling runParagraph() on shif...
Posted by nazgul33 <gi...@git.apache.org>.
Github user nazgul33 commented on the issue:
https://github.com/apache/zeppelin/pull/1336
> However, @nazgul33 next time it would be better to make a separate branch instead of making the PR from master.
can't agree more. lol
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1336: [ZEPPELIN-1333] prevent calling runParagraph() on shif...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1336
@corneadoug It passed selenium test. Is it enough?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---