You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2016/01/04 19:05:06 UTC

Re: Review Request 41555: AMBARI-14408: common-services folder needs to be backed up upon ambari-server RPM upgrade

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41555/#review112605
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Dec. 18, 2015, 4:13 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41555/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 4:13 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-14408
>     https://issues.apache.org/jira/browse/AMBARI-14408
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Need to back up common services folder when running ambari RPM upgrade. Otherwise, if an older version of a given common service is removed, the ambari-server upgrade cmd run will fail with error about the service (older version, removed in newer ambari release) dir does not have a valid metainfo.xml file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/package/deb/control/preinst f640adb 
>   ambari-server/src/main/package/rpm/preinstall.sh 313a169 
> 
> Diff: https://reviews.apache.org/r/41555/diff/
> 
> 
> Testing
> -------
> 
> 1. install ambari 2.1.2/hdp 2.2,
> 2. customize the common service in ambari trunk to make a new dir representing a newer version of solr,
> 3. build ambari server rpm from ambari trunk code, 
> 4.  run yum upgrade -y ambari-server (against a local repo)
> 
> Verify
> 1. the common-services dir from the older ambari server rpm install was backed up as common-services-<timestamp>.old, 
> 2. a new common-services dir was installed during the yum upgrade cmd run
> 3. was able to run ambari-server upgrade cmd successfully and start ambari server successfully
> 
> 
> Thanks,
> 
> Di Li
> 
>