You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ha...@apache.org on 2026/05/14 06:12:36 UTC
(skywalking-banyandb) 26/50: chore(measure): fix stale G5e config test and lint-blocking typos
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch vectorized-query
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit 89c3119ff2b8619b06684be1eb6704dc6b9abbfe
Author: Hongtao Gao <ha...@gmail.com>
AuthorDate: Wed May 13 09:19:05 2026 +0000
chore(measure): fix stale G5e config test and lint-blocking typos
- `TestVectorizedConfig_Default_Disabled_BatchSize1024_Memory256` was
missed in the G5e flip (commit a0dc29e9); rename it and assert
`Enabled == true` to match the new default.
- Two pre-existing typos in `banyand/measure/query_batch.go` were
blocking `make -s lint`: "behaviour" → "behavior" and "marshalled"
→ "marshaled".
---
banyand/measure/query_batch.go | 4 ++--
pkg/query/vectorized/measure/config_test.go | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/banyand/measure/query_batch.go b/banyand/measure/query_batch.go
index 3fdcfc556..b45269dc9 100644
--- a/banyand/measure/query_batch.go
+++ b/banyand/measure/query_batch.go
@@ -311,7 +311,7 @@ func (iqr *indexSortResult) copyToBatch(b *model.MeasureBatch, schema *vectorize
b.Timestamps = append(b.Timestamps, src.Timestamps[rowIdx])
b.Versions = append(b.Versions, src.Versions[rowIdx])
b.SeriesIDs = append(b.SeriesIDs, src.SeriesList[rowIdx].ID)
- // indexSortResult has no shardID; use zero value (matches copyTo behaviour).
+ // indexSortResult has no shardID; use zero value (matches copyTo behavior).
b.ShardIDs = append(b.ShardIDs, 0)
var fr storage.FieldResult
@@ -379,7 +379,7 @@ func (iqr *indexSortResult) fillSegFieldCell(col vectorized.Column, def vectoriz
appendNullFieldN(col, def, 1)
return
}
- // Fields in the FieldResult are keyed by the marshalled index key (tnt.fieldName).
+ // Fields in the FieldResult are keyed by the marshaled index key (tnt.fieldName).
// Walk all tfl entries to find the field's valueType.
for tfIdx := range iqr.tfl {
if tnt, ok := iqr.tfl[tfIdx].fieldToValueType[def.Name]; ok {
diff --git a/pkg/query/vectorized/measure/config_test.go b/pkg/query/vectorized/measure/config_test.go
index 628bd77b2..52ca7119f 100644
--- a/pkg/query/vectorized/measure/config_test.go
+++ b/pkg/query/vectorized/measure/config_test.go
@@ -19,10 +19,10 @@ package measure
import "testing"
-func TestVectorizedConfig_Default_Disabled_BatchSize1024_Memory256(t *testing.T) {
+func TestVectorizedConfig_Default_Enabled_BatchSize1024_Memory256(t *testing.T) {
c := DefaultConfig()
- if c.Enabled {
- t.Fatal("default Enabled must be false (v1 ships disabled)")
+ if !c.Enabled {
+ t.Fatal("default Enabled must be true post-G5e (vectorized path is the default)")
}
if c.BatchSize != 1024 {
t.Fatalf("default BatchSize: want 1024, got %d", c.BatchSize)