You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2013/12/21 01:18:09 UTC

[jira] [Created] (HDFS-5694) remove duplicate PBHelper#convertDatanodeInfo method

Colin Patrick McCabe created HDFS-5694:
------------------------------------------

             Summary: remove duplicate PBHelper#convertDatanodeInfo method
                 Key: HDFS-5694
                 URL: https://issues.apache.org/jira/browse/HDFS-5694
             Project: Hadoop HDFS
          Issue Type: Improvement
    Affects Versions: 2.4.0
            Reporter: Colin Patrick McCabe
            Assignee: Colin Patrick McCabe
            Priority: Minor


We currently have both a {{PBHelper#convertDatanodeInfo}} and a {{PBHelper#convert(DatanodeInfo)}} method.  The duplication causes maintenance overhead, and bugs when someone updates one method but not another (no other methods that I know of in PBHelper are duplicated this way).  Since they do the same thing, we should just have one method.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)