You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/07/13 08:13:36 UTC
[GitHub] [shardingsphere] FlyingZC opened a new issue, #27139: Support parsing Oracle DROP TYPE sql
FlyingZC opened a new issue, #27139:
URL: https://github.com/apache/shardingsphere/issues/27139
# Background
Hi community,
This issue is for #26878.
ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for Oracle SQL parsing in ShardingSphere.
More details:
https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
# Task
This issue is to support more oracle sql parse, as follows:
```sql
DROP TYPE person_t FORCE;
```
```sql
DROP TYPE location_typ FORCE; -- required if previously created
DROP TYPE office_typ FORCE; -- required if previously created
CREATE OR REPLACE TYPE location_typ AS OBJECT (
building_no NUMBER,
city VARCHAR2(40) );
```
```sql
DROP TYPE person_typ FORCE;
-- if previously created
DROP TYPE student_typ FORCE; -- if previously created
DROP TYPE part_time_student_typ FORCE; -- if previously created
DROP TABLE contacts; if previously created
CREATE OR REPLACE TYPE person_typ AS OBJECT (
idno NUMBER,
name VARCHAR2(30),
phone VARCHAR2(20))
NOT FINAL;/
CREATE TYPE student_typ UNDER person_typ (
dept_id NUMBER,
major VARCHAR2(30))
NOT FINAL;
```
```sql
DROP TYPE person_typ FORCE;
-- if previously created
CREATE OR REPLACE TYPE person_typ AS OBJECT (
idno NUMBER,
name VARCHAR2(30),
phone VARCHAR2(20),
NOT INSTANTIABLE MEMBER FUNCTION get_idno RETURN NUMBER)
NOT INSTANTIABLE NOT FINAL;
```
```sql
DROP TYPE person_typ FORCE;
-- if previously created
CREATE TYPE person_typ AS OBJECT (
idno NUMBER,
name VARCHAR2(30),
phone VARCHAR2(20))
NOT FINAL;
```
# Process
1. First confirm that this is a correct oracle sql syntax, if not please ignore;
2. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
4. Run mvn install the current_file_module;
5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML;
7. Run SQLParserParameterizedTest to make sure no exceptions.
# Relevant Skills
1. Master JAVA language
2. Have a basic understanding of Antlr `g4` file
3. Be familiar with Oracle SQLs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support parsing Oracle DROP TYPE sql [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on issue #27139:
URL: https://github.com/apache/shardingsphere/issues/27139#issuecomment-5329273872
Hi @FlyingZC, thanks for the report. This issue has been completed and can be closed.
Oracle `DROP TYPE` parsing was implemented by #27217 (merged into 5.4.1): the `dropType` rule in `parser/sql/engine/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4` covers `DROP TYPE type_name [FORCE | VALIDATE]`, and `OracleDDLStatementVisitor#visitDropType` builds the statement. The Oracle test cases `drop_type`, `drop_type_schema_force` and `drop_type_schema_validate` cover it in `test/it/parser/src/main/resources`. I verified on the current master that all the `DROP TYPE ... FORCE` examples in this issue parse successfully. #27217 referenced #27136 instead of this issue by mistake, which is why it was never closed automatically.
The remaining example `CREATE OR REPLACE TYPE ... (NOT INSTANTIABLE MEMBER FUNCTION ...)` is a `CREATE TYPE` statement, out of the scope of this `DROP TYPE` issue; it can be tracked separately under #26878.
Closing this issue as completed. #27140 duplicates this one and will be closed as duplicate as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] commented on issue #27139: Support parsing Oracle DROP TYPE sql
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27139:
URL: https://github.com/apache/shardingsphere/issues/27139#issuecomment-1678575007
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support parsing Oracle DROP TYPE sql [shardingsphere]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27139:
URL: https://github.com/apache/shardingsphere/issues/27139#issuecomment-1784212767
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] boyjoy1127 commented on issue #27139: Support parsing Oracle DROP TYPE sql
Posted by "boyjoy1127 (via GitHub)" <gi...@apache.org>.
boyjoy1127 commented on issue #27139:
URL: https://github.com/apache/shardingsphere/issues/27139#issuecomment-1636728593
I'd like to support this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support parsing Oracle DROP TYPE sql [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed issue #27139: Support parsing Oracle DROP TYPE sql
URL: https://github.com/apache/shardingsphere/issues/27139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org